Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alchemy_cms.gemspec #1926

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Update alchemy_cms.gemspec #1926

merged 2 commits into from
Aug 24, 2020

Conversation

sechix
Copy link
Contributor

@sechix sechix commented Aug 21, 2020

Let last coffee version works

What is this pull request for?

Solidus last version requires coffee-rails 5.0.0. Make sure that alchemy_cms use at least 5.0.0 version

Let last coffee version works
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We would like to be less optimistic about the next major version. Also would you change the commit message to something that explains the why not the what of your commit?

Maybe just simply?

Allow coffee-rails v5

alchemy_cms.gemspec Outdated Show resolved Hide resolved
Change to lower version not next major version

Co-authored-by: Thomas von Deyen <thomas@vondeyen.com>
@sechix
Copy link
Contributor Author

sechix commented Aug 22, 2020

@tvdeyen done!

@tvdeyen tvdeyen merged commit 2c438fe into AlchemyCMS:master Aug 24, 2020
SirNicholas pushed a commit to SirNicholas/alchemy_cms that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants