Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all Boolean columns to never be null #1933

Merged
merged 1 commit into from Sep 22, 2020
Merged

Change all Boolean columns to never be null #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 33 additions & 0 deletions db/migrate/20200907111332_remove_tri_state_booleans.rb
View file
Open in desktop
@@ -0,0 +1,33 @@
# frozen_string_literal: true

class RemoveTriStateBooleans < ActiveRecord::Migration[5.2]
def change
change_column_null :alchemy_elements, :public, false, false
change_column_default :alchemy_elements, :public, true

change_column_null :alchemy_elements, :folded, false
change_column_null :alchemy_elements, :unique, false

change_column_null :alchemy_essence_richtexts, :public, false, false
change_column_default :alchemy_essence_richtexts, :public, false

change_column_null :alchemy_essence_texts, :public, false

change_column_null :alchemy_folded_pages, :folded, false

change_column_null :alchemy_languages, :public, false
change_column_null :alchemy_languages, :default, false

change_column_null :alchemy_pages, :language_root, false, false
change_column_default :alchemy_pages, :language_root, false

change_column_null :alchemy_pages, :restricted, false
change_column_null :alchemy_pages, :robot_index, false
change_column_null :alchemy_pages, :robot_follow, false
change_column_null :alchemy_pages, :sitemap, false

change_column_null :alchemy_sites, :public, false
change_column_null :alchemy_sites, :redirect_to_primary_host, false, false
change_column_default :alchemy_sites, :redirect_to_primary_host, false
end
end
1 change: 1 addition & 0 deletions spec/dummy/db/migrate/20200907111332_remove_tri_state_booleans.rb
View file
Open in desktop
@@ -0,0 +1 @@
../../../../db/migrate/20200907111332_remove_tri_state_booleans.rb
32 changes: 16 additions & 16 deletions spec/dummy/db/schema.rb
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2020_06_17_110713) do
ActiveRecord::Schema.define(version: 2020_09_07_111332) do

create_table "alchemy_attachments", force: :cascade do |t|
t.string "name"
Expand Down Expand Up @@ -40,9 +40,9 @@
t.string "name"
t.integer "position"
t.integer "page_id", null: false
t.boolean "public", default: true
t.boolean "folded", default: false
t.boolean "unique", default: false
t.boolean "public", default: true, null: false
t.boolean "folded", default: false, null: false
t.boolean "unique", default: false, null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "creator_id"
Expand Down Expand Up @@ -122,7 +122,7 @@
create_table "alchemy_essence_richtexts", force: :cascade do |t|
t.text "body"
t.text "stripped_body"
t.boolean "public"
t.boolean "public", default: false, null: false
end

create_table "alchemy_essence_selects", force: :cascade do |t|
Expand All @@ -135,14 +135,14 @@
t.string "link"
t.string "link_title"
t.string "link_class_name"
t.boolean "public", default: false
t.boolean "public", default: false, null: false
t.string "link_target"
end

create_table "alchemy_folded_pages", force: :cascade do |t|
t.integer "page_id", null: false
t.integer "user_id", null: false
t.boolean "folded", default: false
t.boolean "folded", default: false, null: false
t.index ["page_id", "user_id"], name: "index_alchemy_folded_pages_on_page_id_and_user_id", unique: true
end

Expand All @@ -151,12 +151,12 @@
t.string "language_code"
t.string "frontpage_name"
t.string "page_layout", default: "intro"
t.boolean "public", default: false
t.boolean "public", default: false, null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "creator_id"
t.integer "updater_id"
t.boolean "default", default: false
t.boolean "default", default: false, null: false
t.string "country_code", default: "", null: false
t.integer "site_id", null: false
t.string "locale"
Expand Down Expand Up @@ -208,7 +208,7 @@
t.string "urlname"
t.string "title"
t.string "language_code"
t.boolean "language_root"
t.boolean "language_root", default: false, null: false
t.string "page_layout"
t.text "meta_keywords"
t.text "meta_description"
Expand All @@ -217,10 +217,10 @@
t.integer "parent_id"
t.integer "depth"
t.integer "locked_by"
t.boolean "restricted", default: false
t.boolean "robot_index", default: true
t.boolean "robot_follow", default: true
t.boolean "sitemap", default: true
t.boolean "restricted", default: false, null: false
t.boolean "robot_index", default: true, null: false
t.boolean "robot_follow", default: true, null: false
t.boolean "sitemap", default: true, null: false
t.boolean "layoutpage", default: false, null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
Expand Down Expand Up @@ -271,9 +271,9 @@
t.string "name"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.boolean "public", default: false
t.boolean "public", default: false, null: false
t.text "aliases"
t.boolean "redirect_to_primary_host"
t.boolean "redirect_to_primary_host", default: false, null: false
t.index ["host", "public"], name: "alchemy_sites_public_hosts_idx"
t.index ["host"], name: "index_alchemy_sites_on_host"
end
Expand Down