Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprivatize useful picture view methods #1936

Merged
merged 2 commits into from Oct 14, 2020
Merged

Deprivatize useful picture view methods #1936

merged 2 commits into from Oct 14, 2020

Conversation

mickenorlen
Copy link
Contributor

Useful eg for custom picture tag creation

@mickenorlen
Deprivatize useful picture view methods
8665988 
Useful eg for custom picture tag creation
tvdeyen
tvdeyen reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree with the url and the img_tag methods made public, but why the show_caption? and is_linked? methods as well? Do you need them?

app/models/alchemy/essence_picture_view.rb Outdated
def caption
return unless show_caption?

@_caption ||= content_tag(:figcaption, essence.caption)
end

def img_tag_src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to call this method src or url

@tvdeyen
Copy link
Member

tvdeyen commented Sep 30, 2020

Now that we merged #1940 we need to rebase and resolve conflicts

@mickenorlen
Copy link
Contributor Author

I built my own picture tag helper so i need all the methods thanks.

tvdeyen
tvdeyen approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 2b32de1 into AlchemyCMS:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mickenorlen @tvdeyen