Do not abort if user class cannot be found #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually checkin if the user class is an active record we use the ActiveSupport.on_load callback that gracefully handles auto loading. This should help to avoid early aborts of user class missing errrors during boot time.
While setting up a fresh Alchemy in a project that has a custom user class and has not told Alchemy yet about it, we must not raise an error if the user class is missing.
tvdeyen
force-pushed
the
better-user-stamper
branch
from
e21fd11
to
3423a65
Compare
tvdeyen
changed the title
mamhoff
approved these changes
Oct 21, 2020
If a user class has not been set yet we must not raise, so we do not interupt booting the application. Instead log a helpful warning.
tvdeyen
force-pushed
the
better-user-stamper
branch
from
3423a65
to
385d120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We must not abort the Rails boot process if a user class has not been set or cannot be found. Instead we log a warning and return
nilasAlchemy.user_class.It is now important that no extension or app code expects that a
Alchemy.user_classexists.An accompany PR has been made to
alchemy-solidusAlchemyCMS/alchemy-solidus#69Checklist