Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple preview sources #1959

Merged
merged 4 commits into from Nov 6, 2020
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 2, 2020

What is this pull request for?

Includes #1957

Currently only one page preview source is available. Allowing to add more preview sources the user can select from makes it possible to see the same page content in different contexts (Static Frontends, A/B-Testing, etc.)

Screenshots

Alchemy CMS - Black Lives Matter 2020-11-02 09-39-23

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 5.1 milestone Nov 2, 2020
@tvdeyen tvdeyen requested a review from mamhoff November 2, 2020 08:43
@tvdeyen tvdeyen self-assigned this Nov 2, 2020
Currently only one page preview source is available. Allowing to add more preview sources the user can select from makes it possible to see the same page content in different contexts (Static Frontends, A/B-Testing, etc.)
This allows us to send and receive focusElement and focusElementEditor messages from the preview window to the elements window and vice versa.
@tvdeyen tvdeyen merged commit 210b3d1 into AlchemyCMS:main Nov 6, 2020
@tvdeyen tvdeyen deleted the preview-sources branch November 6, 2020 10:44
tvdeyen added a commit that referenced this pull request Nov 6, 2020
- Allow multiple preview sources [#1959](#1959) ([tvdeyen](https://github.com/tvdeyen))
- Add Publish Targets [#1957](#1957) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants