Resource filter fixes #2665
Merged
Resource filter fixes #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
resource-filter-fixes
branch
from
30565cd
to
c9c389f
Compare
We need to use the permitted search filter params in order to have the correct filter selected.
Rails 7 params do not inherit from `Hash` anymore. In order to keep existing filters we need to check for `ActionController::Parameters`.
tvdeyen
force-pushed
the
resource-filter-fixes
branch
from
c9c389f
to
d006e02
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Jan 4, 2024
[7.0-stable] Merge pull request #2665 from tvdeyen/resource-filter-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fixes for resource filters and Rails 7
Checklist