Use svg remixicons #2749
Merged
Use svg remixicons #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
use-svg-remixicons
branch
8 times, most recently
from
3fe5e84
to
9c30914
Compare
tvdeyen
force-pushed
the
use-svg-remixicons
branch
4 times, most recently
from
339067c
to
7a15c05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2749 +/- ##
=======================================
Coverage 95.80% 95.81%
=======================================
Files 221 222 +1
Lines 6078 6087 +9
=======================================
+ Hits 5823 5832 +9
Misses 255 255 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
use-svg-remixicons
branch
from
7a15c05
to
d5afd97
Compare
tvdeyen
commented
Mar 12, 2024
app/assets/javascripts/alchemy/alchemy.preview_window.js.coffee
Outdated
Show resolved
Hide resolved
This introduces a new <alchemy-icon> custom element which you can use as replacement for <i> tags.
We use the svg icon sprite now
For testing that feature
tvdeyen
force-pushed
the
use-svg-remixicons
branch
from
d5afd97
to
7fb12a0
Compare
sascha-karnatz
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of a iconfont we use the svg icon sprite to render icons. This includes a new component
<alchemy-icon>withname,sizeandicon-styleprops.With rails/rails#50359 being merged svgs will be precompressed during asset compilation, which makes a huge difference on transferred file size.
Notable changes
Removes the icon fonts and
ri-classes for<i>elements.Checklist