Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 422 on validation error #2869

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 10, 2024

What is this pull request for?

Describe you pull request here...

Closes # (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Instead of returning 200 (ok) we should return 422
(unprocessible content) and display the error messages.
and close the dialog on successful remote form submit.
@tvdeyen tvdeyen force-pushed the return-422-on-validation-error branch from e075777 to be37572 Compare May 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant