Fix link selection of internal root or locale urls #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The url for rootpages (`/`) or locales (`/en`) are not the urlname of a page. This fixes the selection of internal links for these pages in the Link Dialog.
tvdeyen
force-pushed
the
fix-internal-link-selection
branch
from
58c6e22
to
1fe1918
Compare
sascha-karnatz
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
=======================================
Coverage 95.95% 95.96%
=======================================
Files 230 230
Lines 6258 6269 +11
=======================================
+ Hits 6005 6016 +11
Misses 253 253 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The url for rootpages (
/) or locales (/en) are not the urlname of a page. This fixes the selection of internal links for these pages in the Link Dialog.Checklist