Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable preview sizes #2923

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 6, 2024

What is this pull request for?

You are now able to configure preview sizes in the alchemy/config.yml file.

page_preview_sizes:
  - 360
  - 640
  - 768
  - 1024
  - 1280
  - 1440

and adjust them to your breakpoints. Translate the value with alchemy.preview_sizes.<value> in your locale file.

Notable changes

Use normal select for preview sizes

Screenshots

Alchemy CMS - Startseite 2024-06-06 23-23-09

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner June 6, 2024 21:24
@tvdeyen tvdeyen added this to the 7.3 milestone Jun 6, 2024
You are now able to configure preview sizes in the
`alchemy/config.yml` file.

    page_preview_sizes:
      - 360
      - 640
      - 768
      - 1024
      - 1280
      - 1440

and adjust them to your breakpoints. Translate the value
with `alchemy.preview_sizes.<value>` in your locale file.
More accessible and one less select2 instance.
@tvdeyen tvdeyen enabled auto-merge June 7, 2024 13:28
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (efb901e) to head (f055396).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2923   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         232      232           
  Lines        6279     6280    +1     
=======================================
+ Hits         6026     6027    +1     
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit a4e5786 into AlchemyCMS:main Jun 7, 2024
35 checks passed
@tvdeyen tvdeyen deleted the adjust-preview-viewports branch June 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants