Allow subclasses to run custom logic when connected. Try to fix test …

…that is failing in CI but not locally.
Aldaviva · Apr 9, 2023 · 9ba8696 · 9ba8696
1 parent 999e24c
commit 9ba8696
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/HidClient/AbstractHidClient.cs b/HidClient/AbstractHidClient.cs
@@ -95,13 +95,16 @@ public abstract class AbstractHidClient: IHidClient {
             DeviceStream.ReadTimeout =  Timeout.Infinite;
             _cancellationTokenSource =  new CancellationTokenSource();
             IsConnected              =  true;
+            OnConnect();
 
             try {
                 Task.Factory.StartNew(HidReadLoop, _cancellationTokenSource.Token, TaskCreationOptions.LongRunning, TaskScheduler.Default);
             } catch (TaskCanceledException) { }
         }
     }
 
+    protected virtual void OnConnect() { }
+
     private async Task HidReadLoop() {
         CancellationToken cancellationToken = _cancellationTokenSource!.Token;
 

diff --git a/Tests/HidClientInputTest.cs b/Tests/HidClientInputTest.cs
@@ -107,14 +107,18 @@ public class HidClientInputTest {
     [Fact]
     public void SynchronizationContext() {
         A.CallTo(() => _stream.ReadAsync(A<byte[]>._, An<int>._, An<int>._, A<CancellationToken>._))
-            .ThrowsAsync(new IOException("fake disconnected")).Once().Then
-            .ReturnsLazily(FakeReadAsync(5, 6, 7));
+            .ThrowsAsync(new IOException("fake disconnected"));
 
         ManualResetEventSlim   eventArrived           = new();
         SynchronizationContext synchronizationContext = A.Fake<SynchronizationContext>();
         A.CallTo(() => synchronizationContext.Post(A<SendOrPostCallback>._, An<object?>._)).Invokes(() => eventArrived.Set());
 
-        FakeHidClient client = new(_deviceList) { EventSynchronizationContext = synchronizationContext };
+        using FakeHidClient client = new(_deviceList) { EventSynchronizationContext = synchronizationContext };
+
+        A.CallTo(() => _stream.ReadAsync(A<byte[]>._, An<int>._, An<int>._, A<CancellationToken>._))
+            .ThrowsAsync(new IOException("fake disconnected")).Once().Then
+            .ReturnsLazily(FakeReadAsync(5, 6, 7));
+
         eventArrived.Wait(TestTimeout);
 
         A.CallTo(() => synchronizationContext.Post(A<SendOrPostCallback>._, An<object?>._)).MustHaveHappenedOnceOrMore();