Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/upload #17

Merged
merged 11 commits into from
May 4, 2018
Merged

Component/upload #17

merged 11 commits into from
May 4, 2018

Conversation

meinstein
Copy link
Contributor

@meinstein meinstein commented May 2, 2018

Added two components to the Form section in quark-web. They are:

  • FilePicker
  • ImagePicker

Provided a short and sweet description for each in their respective READMEs

TODO:

  • fix flow errors
  • type the file object

@meinstein meinstein requested a review from AlecAivazis May 2, 2018 08:30
@coveralls
Copy link

coveralls commented May 2, 2018

Coverage Status

Coverage decreased (-1.0%) to 68.695% when pulling df43ea3 on component/upload into bc2b900 on master.

@meinstein
Copy link
Contributor Author

I could use a hand looking at these flow errors when you have a chance. I want to make sure these components are ready so you can use them on the create modal

@AlecAivazis
Copy link
Owner

@meinstein - i addressed all of the flow errors, there were a few weird bits that I think were artifacts from the previous state when the onChange was returning a string. I also made the onChange for the components component return a list of files so the user is allowed to upload more than one file at once.

@AlecAivazis AlecAivazis merged commit 0276ed3 into master May 4, 2018
@AlecAivazis AlecAivazis deleted the component/upload branch May 4, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants