This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Panic index out of range; selectedIndex should not be a negative number #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using AskOne, filtering and using arrow keys can result in a panic. Add checks to make sure that selectedIndex does not contain a negative number.
|
Additional details in BZ if curious: https://bugzilla.redhat.com/show_bug.cgi?id=1775569 |
AlecAivazis
approved these changes
Feb 17, 2020
|
Would you mind cherry picking this onto v2? |
|
@AlecAivazis I have test code that I can try to see if I can reproduce with v2. There were differences so I don't think it will cleaning CP. |
|
Ah that might definitely be the case. If you have the time to verify, that would save me having to add another item to my list of stuff to do 🙌 |
|
@AlecAivazis tested with v2 no panic. |
|
awesome! Thanks for checking |
This was referenced Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AskOne, filtering and using arrow keys can result in
a panic. Add checks to make sure that selectedIndex does
not contain a negative number.