Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Survey output on Windows #413

Merged
merged 1 commit into from Mar 22, 2022
Merged

Fix Survey output on Windows #413

merged 1 commit into from Mar 22, 2022

Conversation

mislav
Copy link
Collaborator

@mislav mislav commented Mar 21, 2022

Fixes Survey on Windows.

When I was tightening out error handling in #404, it didn't occur to me that some errors want to be ignored.

@mislav mislav merged commit 6cbb195 into master Mar 22, 2022
12 checks passed
@mislav mislav deleted the fix-windows branch Mar 22, 2022
aviator-app bot pushed a commit to airplanedev/cli that referenced this pull request Mar 24, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/AlecAivazis/survey/v2](https://togithub.com/AlecAivazis/survey) | require | patch | `v2.3.2` -> `v2.3.4` |
| [github.com/airplanedev/lib](https://togithub.com/airplanedev/lib) | require | patch | `v0.4.0` -> `v0.4.1` |

---

### Release Notes

<details>
<summary>AlecAivazis/survey</summary>

### [`v2.3.4`](https://togithub.com/AlecAivazis/survey/releases/v2.3.4)

[Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.3...v2.3.4)

#### What's Changed

-   Fix Survey output on Windows by [@&#8203;mislav](https://togithub.com/mislav) in AlecAivazis/survey#413
-   Add `terminal.Cursor` error handling on Windows by [@&#8203;mislav](https://togithub.com/mislav) in AlecAivazis/survey#414

**Full Changelog**: AlecAivazis/survey@v2.3.3...v2.3.4

### [`v2.3.3`](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3)

[Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3)

</details>

<details>
<summary>airplanedev/lib</summary>

### [`v0.4.1`](https://togithub.com/airplanedev/lib/compare/v0.4.0...v0.4.1)

[Compare Source](https://togithub.com/airplanedev/lib/compare/v0.4.0...v0.4.1)

</details>

---

### Configuration

📅 **Schedule**: "before 5am on Thursday" in timezone America/New_York.

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
aviator-app bot pushed a commit to airplanedev/lib that referenced this pull request Mar 30, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/AlecAivazis/survey/v2](https://togithub.com/AlecAivazis/survey) | require | patch | `v2.3.2` -> `v2.3.4` |
| [github.com/evanw/esbuild](https://togithub.com/evanw/esbuild) | require | patch | `v0.14.27` -> `v0.14.29` |

---

### Release Notes

<details>
<summary>AlecAivazis/survey</summary>

### [`v2.3.4`](https://togithub.com/AlecAivazis/survey/releases/v2.3.4)

[Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.3...v2.3.4)

#### What's Changed

-   Fix Survey output on Windows by [@&#8203;mislav](https://togithub.com/mislav) in AlecAivazis/survey#413
-   Add `terminal.Cursor` error handling on Windows by [@&#8203;mislav](https://togithub.com/mislav) in AlecAivazis/survey#414

**Full Changelog**: AlecAivazis/survey@v2.3.3...v2.3.4

### [`v2.3.3`](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3)

[Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3)

</details>

<details>
<summary>evanw/esbuild</summary>

### [`v0.14.29`](https://togithub.com/evanw/esbuild/releases/v0.14.29)

[Compare Source](https://togithub.com/evanw/esbuild/compare/v0.14.28...v0.14.29)

-   Fix a minification bug with a double-nested `if` inside a label followed by `else` ([#&#8203;2139](https://togithub.com/evanw/esbuild/issues/2139))

    This fixes a minification bug that affects the edge case where `if` is followed by `else` and the `if` contains a label that contains a nested `if`. Normally esbuild's AST printer automatically wraps the body of a single-statement `if` in braces to avoid the "dangling else" `if`/`else` ambiguity common to C-like languages (where the `else` accidentally becomes associated with the inner `if` instead of the outer `if`). However, I was missing automatic wrapping of label statements, which did not have test coverage because they are a rarely-used feature. This release fixes the bug:

    ```js
    // Original code
    if (a)
      b: {
        if (c) break b
      }
    else if (d)
      e()

    // Old output (with --minify)
    if(a)e:if(c)break e;else d&&e();

    // New output (with --minify)
    if(a){e:if(c)break e}else d&&e();
    ```

-   Fix edge case regarding `baseUrl` and `paths` in `tsconfig.json` ([#&#8203;2119](https://togithub.com/evanw/esbuild/issues/2119))

    In `tsconfig.json`, TypeScript forbids non-relative values inside `paths` if `baseUrl` is not present, and esbuild does too. However, TypeScript checked this after the entire `tsconfig.json` hierarchy was parsed while esbuild incorrectly checked this immediately when parsing the file containing the `paths` map. This caused incorrect warnings to be generated for `tsconfig.json` files that specify a `baseUrl` value and that inherit a `paths` value from an `extends` clause. Now esbuild will only check for non-relative `paths` values after the entire hierarchy has been parsed to avoid generating incorrect warnings.

-   Better handle errors where the esbuild binary executable is corrupted or missing ([#&#8203;2129](https://togithub.com/evanw/esbuild/issues/2129))

    If the esbuild binary executable is corrupted or missing, previously there was one situation where esbuild's JavaScript API could hang instead of generating an error. This release changes esbuild's library code to generate an error instead in this case.

### [`v0.14.28`](https://togithub.com/evanw/esbuild/releases/v0.14.28)

[Compare Source](https://togithub.com/evanw/esbuild/compare/v0.14.27...v0.14.28)

-   Add support for some new CSS rules ([#&#8203;2115](https://togithub.com/evanw/esbuild/issues/2115), [#&#8203;2116](https://togithub.com/evanw/esbuild/issues/2116), [#&#8203;2117](https://togithub.com/evanw/esbuild/issues/2117))

    This release adds support for [`@font-palette-values`](https://drafts.csswg.org/css-fonts-4/#font-palette-values), [`@counter-style`](https://developer.mozilla.org/en-US/docs/Web/CSS/@&#8203;counter-style), and [`@font-feature-values`](https://developer.mozilla.org/en-US/docs/Web/CSS/@&#8203;font-feature-values). This means esbuild will now pretty-print and minify these rules better since it now better understands the internal structure of these rules:

    ```css
    /* Original code */
    @&#8203;font-palette-values Foo { base-palette: 1; }
    @&#8203;counter-style bar { symbols: b a r; }
    @&#8203;font-feature-values Bop { @&#8203;styleset { test: 1; } }

    /* Old output (with --minify) */
    @&#8203;font-palette-values Foo{base-palette: 1;}@&#8203;counter-style bar{symbols: b a r;}@&#8203;font-feature-values Bop{@&#8203;styleset {test: 1;}}

    /* New output (with --minify) */
    @&#8203;font-palette-values Foo{base-palette:1}@&#8203;counter-style bar{symbols:b a r}@&#8203;font-feature-values Bop{@&#8203;styleset{test:1}}
    ```

-   Upgrade to Go 1.18.0 ([#&#8203;2105](https://togithub.com/evanw/esbuild/issues/2105))

    Binary executables for this version are now published with Go version 1.18.0. The [Go release notes](https://go.dev/doc/go1.18) say that the linker generates smaller binaries and that on 64-bit ARM chips, compiled binaries run around 10% faster. On an M1 MacBook Pro, esbuild's benchmark runs approximately 8% faster than before and the binary executable is approximately 4% smaller than before.

    This also fixes a regression from version 0.14.26 of esbuild where the browser builds of the `esbuild-wasm` package could fail to be bundled due to the use of built-in node libraries. The primary WebAssembly shim for Go 1.18.0 no longer uses built-in node libraries.

</details>

---

### Configuration

📅 **Schedule**: "before 5am on Thursday" in timezone America/New_York.

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant