This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
Fix Survey output on Windows #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2022
Merged
aviator-app bot
pushed a commit
to airplanedev/cli
that referenced
this pull request
Mar 24, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/AlecAivazis/survey/v2](https://togithub.com/AlecAivazis/survey) | require | patch | `v2.3.2` -> `v2.3.4` | | [github.com/airplanedev/lib](https://togithub.com/airplanedev/lib) | require | patch | `v0.4.0` -> `v0.4.1` | --- ### Release Notes <details> <summary>AlecAivazis/survey</summary> ### [`v2.3.4`](https://togithub.com/AlecAivazis/survey/releases/v2.3.4) [Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.3...v2.3.4) #### What's Changed - Fix Survey output on Windows by [@​mislav](https://togithub.com/mislav) in AlecAivazis/survey#413 - Add `terminal.Cursor` error handling on Windows by [@​mislav](https://togithub.com/mislav) in AlecAivazis/survey#414 **Full Changelog**: AlecAivazis/survey@v2.3.3...v2.3.4 ### [`v2.3.3`](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3) [Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3) </details> <details> <summary>airplanedev/lib</summary> ### [`v0.4.1`](https://togithub.com/airplanedev/lib/compare/v0.4.0...v0.4.1) [Compare Source](https://togithub.com/airplanedev/lib/compare/v0.4.0...v0.4.1) </details> --- ### Configuration 📅 **Schedule**: "before 5am on Thursday" in timezone America/New_York. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
This was referenced Mar 26, 2022
Open
aviator-app bot
pushed a commit
to airplanedev/lib
that referenced
this pull request
Mar 30, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/AlecAivazis/survey/v2](https://togithub.com/AlecAivazis/survey) | require | patch | `v2.3.2` -> `v2.3.4` | | [github.com/evanw/esbuild](https://togithub.com/evanw/esbuild) | require | patch | `v0.14.27` -> `v0.14.29` | --- ### Release Notes <details> <summary>AlecAivazis/survey</summary> ### [`v2.3.4`](https://togithub.com/AlecAivazis/survey/releases/v2.3.4) [Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.3...v2.3.4) #### What's Changed - Fix Survey output on Windows by [@​mislav](https://togithub.com/mislav) in AlecAivazis/survey#413 - Add `terminal.Cursor` error handling on Windows by [@​mislav](https://togithub.com/mislav) in AlecAivazis/survey#414 **Full Changelog**: AlecAivazis/survey@v2.3.3...v2.3.4 ### [`v2.3.3`](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3) [Compare Source](https://togithub.com/AlecAivazis/survey/compare/v2.3.2...v2.3.3) </details> <details> <summary>evanw/esbuild</summary> ### [`v0.14.29`](https://togithub.com/evanw/esbuild/releases/v0.14.29) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.14.28...v0.14.29) - Fix a minification bug with a double-nested `if` inside a label followed by `else` ([#​2139](https://togithub.com/evanw/esbuild/issues/2139)) This fixes a minification bug that affects the edge case where `if` is followed by `else` and the `if` contains a label that contains a nested `if`. Normally esbuild's AST printer automatically wraps the body of a single-statement `if` in braces to avoid the "dangling else" `if`/`else` ambiguity common to C-like languages (where the `else` accidentally becomes associated with the inner `if` instead of the outer `if`). However, I was missing automatic wrapping of label statements, which did not have test coverage because they are a rarely-used feature. This release fixes the bug: ```js // Original code if (a) b: { if (c) break b } else if (d) e() // Old output (with --minify) if(a)e:if(c)break e;else d&&e(); // New output (with --minify) if(a){e:if(c)break e}else d&&e(); ``` - Fix edge case regarding `baseUrl` and `paths` in `tsconfig.json` ([#​2119](https://togithub.com/evanw/esbuild/issues/2119)) In `tsconfig.json`, TypeScript forbids non-relative values inside `paths` if `baseUrl` is not present, and esbuild does too. However, TypeScript checked this after the entire `tsconfig.json` hierarchy was parsed while esbuild incorrectly checked this immediately when parsing the file containing the `paths` map. This caused incorrect warnings to be generated for `tsconfig.json` files that specify a `baseUrl` value and that inherit a `paths` value from an `extends` clause. Now esbuild will only check for non-relative `paths` values after the entire hierarchy has been parsed to avoid generating incorrect warnings. - Better handle errors where the esbuild binary executable is corrupted or missing ([#​2129](https://togithub.com/evanw/esbuild/issues/2129)) If the esbuild binary executable is corrupted or missing, previously there was one situation where esbuild's JavaScript API could hang instead of generating an error. This release changes esbuild's library code to generate an error instead in this case. ### [`v0.14.28`](https://togithub.com/evanw/esbuild/releases/v0.14.28) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.14.27...v0.14.28) - Add support for some new CSS rules ([#​2115](https://togithub.com/evanw/esbuild/issues/2115), [#​2116](https://togithub.com/evanw/esbuild/issues/2116), [#​2117](https://togithub.com/evanw/esbuild/issues/2117)) This release adds support for [`@font-palette-values`](https://drafts.csswg.org/css-fonts-4/#font-palette-values), [`@counter-style`](https://developer.mozilla.org/en-US/docs/Web/CSS/@​counter-style), and [`@font-feature-values`](https://developer.mozilla.org/en-US/docs/Web/CSS/@​font-feature-values). This means esbuild will now pretty-print and minify these rules better since it now better understands the internal structure of these rules: ```css /* Original code */ @​font-palette-values Foo { base-palette: 1; } @​counter-style bar { symbols: b a r; } @​font-feature-values Bop { @​styleset { test: 1; } } /* Old output (with --minify) */ @​font-palette-values Foo{base-palette: 1;}@​counter-style bar{symbols: b a r;}@​font-feature-values Bop{@​styleset {test: 1;}} /* New output (with --minify) */ @​font-palette-values Foo{base-palette:1}@​counter-style bar{symbols:b a r}@​font-feature-values Bop{@​styleset{test:1}} ``` - Upgrade to Go 1.18.0 ([#​2105](https://togithub.com/evanw/esbuild/issues/2105)) Binary executables for this version are now published with Go version 1.18.0. The [Go release notes](https://go.dev/doc/go1.18) say that the linker generates smaller binaries and that on 64-bit ARM chips, compiled binaries run around 10% faster. On an M1 MacBook Pro, esbuild's benchmark runs approximately 8% faster than before and the binary executable is approximately 4% smaller than before. This also fixes a regression from version 0.14.26 of esbuild where the browser builds of the `esbuild-wasm` package could fail to be bundled due to the use of built-in node libraries. The primary WebAssembly shim for Go 1.18.0 no longer uses built-in node libraries. </details> --- ### Configuration 📅 **Schedule**: "before 5am on Thursday" in timezone America/New_York. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
1 task
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Survey on Windows.
When I was tightening out error handling in #404, it didn't occur to me that some errors want to be ignored.