Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator bugfixes #188

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Spectator bugfixes #188

merged 5 commits into from
Mar 6, 2024

Conversation

AlecM33
Copy link
Owner

@AlecM33 AlecM33 commented Mar 6, 2024

Fixes #186 and #187. There were two simple causes for these issues:

  • we were not adding the "player options" modal to the DOM for the "in progress" game state. This prevented us from being able to bring up this modal when clicking a spectator's kabab menu when the game is in progress.
  • In the front-end logic, we simply did not handle the fact that spectators can be kicked after the game has been started (probably because we noted players cannot be kicked during the game, but forgot to preserve the functionality for spectators). Specifically we forgot to add the event handling - we fired off the event to the server, but did not process the resulting state change. Just adding that socket handler to the InProgress module fixed the problem.

@AlecM33 AlecM33 merged commit 7e71bbb into master Mar 6, 2024
3 checks passed
@AlecM33 AlecM33 deleted the spectator-bugs branch March 9, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the kabab menu of a spectator can fail to open, throwing a TypeError
1 participant