Skip to content

Commit

Permalink
Run the worker specs with each backend
Browse files Browse the repository at this point in the history
  • Loading branch information
@bkeepers
bkeepers committed Mar 26, 2010
1 parent 36b558d commit b5cabbd
Showing 1 changed file with 124 additions and 127 deletions.
251 changes: 124 additions & 127 deletions spec/worker_spec.rb
View file
Expand Up @@ -5,21 +5,6 @@ def job_create(opts = {})
Delayed::Job.create(opts.merge(:payload_object => SimpleJob.new))
end

before(:all) do
Delayed::Worker.send :public, :work_off
end

before(:each) do
# Make sure backend is set to active record
Delayed::Worker.backend = DEFAULT_BACKEND

@worker = Delayed::Worker.new(:max_priority => nil, :min_priority => nil, :quiet => true)

Delayed::Job.delete_all

SimpleJob.runs = 0
end

describe "backend=" do
it "should set the Delayed::Job constant to the backend" do
@clazz = Class.new
Expand All @@ -34,145 +19,157 @@ def job_create(opts = {})
end
end

describe "running a job" do
it "should fail after Worker.max_run_time" do
begin
old_max_run_time = Delayed::Worker.max_run_time
Delayed::Worker.max_run_time = 1.second
@job = Delayed::Job.create :payload_object => LongRunningJob.new
@worker.run(@job)
@job.reload.last_error.should =~ /expired/
@job.attempts.should == 1
ensure
Delayed::Worker.max_run_time = old_max_run_time
[:active_record, :mongo_mapper].each do |backend|
describe "with the #{backend} backend" do
before do
Delayed::Worker.backend = backend
Delayed::Job.delete_all

@worker = Delayed::Worker.new(:max_priority => nil, :min_priority => nil, :quiet => true)

SimpleJob.runs = 0
end
end
end

context "worker prioritization" do
before(:each) do
@worker = Delayed::Worker.new(:max_priority => 5, :min_priority => -5, :quiet => true)
end
describe "running a job" do
it "should fail after Worker.max_run_time" do
begin
old_max_run_time = Delayed::Worker.max_run_time
Delayed::Worker.max_run_time = 1.second
@job = Delayed::Job.create :payload_object => LongRunningJob.new
@worker.run(@job)
@job.reload.last_error.should =~ /expired/
@job.attempts.should == 1
ensure
Delayed::Worker.max_run_time = old_max_run_time
end
end
end

context "worker prioritization" do
before(:each) do
@worker = Delayed::Worker.new(:max_priority => 5, :min_priority => -5, :quiet => true)
end

it "should only work_off jobs that are >= min_priority" do
SimpleJob.runs.should == 0
it "should only work_off jobs that are >= min_priority" do
SimpleJob.runs.should == 0

job_create(:priority => -10)
job_create(:priority => 0)
@worker.work_off
job_create(:priority => -10)
job_create(:priority => 0)
@worker.work_off

SimpleJob.runs.should == 1
end
SimpleJob.runs.should == 1
end

it "should only work_off jobs that are <= max_priority" do
SimpleJob.runs.should == 0
it "should only work_off jobs that are <= max_priority" do
SimpleJob.runs.should == 0

job_create(:priority => 10)
job_create(:priority => 0)
job_create(:priority => 10)
job_create(:priority => 0)

@worker.work_off
@worker.work_off

SimpleJob.runs.should == 1
end
end
SimpleJob.runs.should == 1
end
end

context "while running with locked and expired jobs" do
before(:each) do
@worker.name = 'worker1'
end
context "while running with locked and expired jobs" do
before(:each) do
@worker.name = 'worker1'
end

it "should not run jobs locked by another worker" do
job_create(:locked_by => 'other_worker', :locked_at => (Delayed::Job.db_time_now - 1.minutes))
lambda { @worker.work_off }.should_not change { SimpleJob.runs }
end
it "should not run jobs locked by another worker" do
job_create(:locked_by => 'other_worker', :locked_at => (Delayed::Job.db_time_now - 1.minutes))
lambda { @worker.work_off }.should_not change { SimpleJob.runs }
end

it "should run open jobs" do
job_create
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end
it "should run open jobs" do
job_create
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end

it "should run expired jobs" do
expired_time = Delayed::Job.db_time_now - (1.minutes + Delayed::Worker.max_run_time)
job_create(:locked_by => 'other_worker', :locked_at => expired_time)
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end
it "should run expired jobs" do
expired_time = Delayed::Job.db_time_now - (1.minutes + Delayed::Worker.max_run_time)
job_create(:locked_by => 'other_worker', :locked_at => expired_time)
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end

it "should run own jobs" do
job_create(:locked_by => @worker.name, :locked_at => (Delayed::Job.db_time_now - 1.minutes))
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end
end
it "should run own jobs" do
job_create(:locked_by => @worker.name, :locked_at => (Delayed::Job.db_time_now - 1.minutes))
lambda { @worker.work_off }.should change { SimpleJob.runs }.from(0).to(1)
end
end

describe "failed jobs" do
before do
# reset defaults
Delayed::Worker.destroy_failed_jobs = true
Delayed::Worker.max_attempts = 25
describe "failed jobs" do
before do
# reset defaults
Delayed::Worker.destroy_failed_jobs = true
Delayed::Worker.max_attempts = 25

@job = Delayed::Job.enqueue ErrorJob.new
end
@job = Delayed::Job.enqueue ErrorJob.new
end

it "should record last_error when destroy_failed_jobs = false, max_attempts = 1" do
Delayed::Worker.destroy_failed_jobs = false
Delayed::Worker.max_attempts = 1
@worker.run(@job)
@job.reload
@job.last_error.should =~ /did not work/
@job.last_error.should =~ /worker_spec.rb/
@job.attempts.should == 1
@job.failed_at.should_not be_nil
end
it "should record last_error when destroy_failed_jobs = false, max_attempts = 1" do
Delayed::Worker.destroy_failed_jobs = false
Delayed::Worker.max_attempts = 1
@worker.run(@job)
@job.reload
@job.last_error.should =~ /did not work/
@job.last_error.should =~ /worker_spec.rb/
@job.attempts.should == 1
@job.failed_at.should_not be_nil
end

it "should re-schedule jobs after failing" do
@worker.run(@job)
@job.reload
@job.last_error.should =~ /did not work/
@job.last_error.should =~ /sample_jobs.rb:8:in `perform'/
@job.attempts.should == 1
@job.run_at.should > Delayed::Job.db_time_now - 10.minutes
@job.run_at.should < Delayed::Job.db_time_now + 10.minutes
end
end
it "should re-schedule jobs after failing" do
@worker.run(@job)
@job.reload
@job.last_error.should =~ /did not work/
@job.last_error.should =~ /sample_jobs.rb:8:in `perform'/
@job.attempts.should == 1
@job.run_at.should > Delayed::Job.db_time_now - 10.minutes
@job.run_at.should < Delayed::Job.db_time_now + 10.minutes
end
end

context "reschedule" do
before do
@job = Delayed::Job.create :payload_object => SimpleJob.new
end
context "reschedule" do
before do
@job = Delayed::Job.create :payload_object => SimpleJob.new
end

context "and we want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = true
end
context "and we want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = true
end

it "should be destroyed if it failed more than Worker.max_attempts times" do
@job.should_receive(:destroy)
Delayed::Worker.max_attempts.times { @worker.reschedule(@job) }
end
it "should be destroyed if it failed more than Worker.max_attempts times" do
@job.should_receive(:destroy)
Delayed::Worker.max_attempts.times { @worker.reschedule(@job) }
end

it "should not be destroyed if failed fewer than Worker.max_attempts times" do
@job.should_not_receive(:destroy)
(Delayed::Worker.max_attempts - 1).times { @worker.reschedule(@job) }
end
end
it "should not be destroyed if failed fewer than Worker.max_attempts times" do
@job.should_not_receive(:destroy)
(Delayed::Worker.max_attempts - 1).times { @worker.reschedule(@job) }
end
end

context "and we don't want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = false
end
context "and we don't want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = false
end

it "should be failed if it failed more than Worker.max_attempts times" do
@job.reload.failed_at.should == nil
Delayed::Worker.max_attempts.times { @worker.reschedule(@job) }
@job.reload.failed_at.should_not == nil
end
it "should be failed if it failed more than Worker.max_attempts times" do
@job.reload.failed_at.should == nil
Delayed::Worker.max_attempts.times { @worker.reschedule(@job) }
@job.reload.failed_at.should_not == nil
end

it "should not be failed if it failed fewer than Worker.max_attempts times" do
(Delayed::Worker.max_attempts - 1).times { @worker.reschedule(@job) }
@job.reload.failed_at.should == nil
end
it "should not be failed if it failed fewer than Worker.max_attempts times" do
(Delayed::Worker.max_attempts - 1).times { @worker.reschedule(@job) }
@job.reload.failed_at.should == nil
end

end
end
end
end


end

0 comments on commit b5cabbd

Please sign in to comment.