Custom functions should not be defined in template files

[pnikolov]

CarBlogTheme/archive.php

Lines 67 to 97 in 29593b1

	/**
	*
	* @param string $taxonomy - the name of the taxonomy to be filtered
	* @param string $slug
	*/
	function compose_url(string $taxonomy, string $slug)
	{
	$slug = esc_attr($slug);
	$url = "?{$taxonomy}[]=" . esc_attr($slug);
	foreach (get_request_params() as $get_by => $args)
	{
	// allows selection of both: several or one (brand/engines)
	//
	if (in_array($slug, $args))
	{
	continue;
	}
	foreach ($args as $arg)
	{
	if ($arg == $slug)
	{
	continue;
	}
	$url .= "&{$get_by}[]=" . esc_attr($arg);
	}
	}
	echo $url;
	}

The compose_url() function should not be defined in the archive.php file - all the template files defined in the WordPress Template Hierarchy should be used only for templating purposes.

Also, can you clarify the double filtering of the $args for $slug and the actual conditions, they seem reversed.

[AleksandarDzh]

The double filtering was pointless because it was basically the same. It's most likely something I forgot to remove. Thank you