refactor pacakge_type -> package_or_packages

AleoHQ · Feb 9, 2021 · d211d72 · d211d72
1 parent f7add0f
commit d211d72
Show file tree

Hide file tree

Showing 8 changed files with 42 additions and 38 deletions.
diff --git a/asg/src/program/mod.rs b/asg/src/program/mod.rs
@@ -25,7 +25,7 @@ mod function;
 pub use function::*;
 
 use crate::{AsgConvertError, ImportResolver, InnerScope, Input, Scope};
-use leo_ast::{Identifier, PackageAccess, PackageType, Span};
+use leo_ast::{Identifier, PackageAccess, PackageOrPackages, Span};
 
 use indexmap::IndexMap;
 use std::{cell::RefCell, sync::Arc};
@@ -74,14 +74,14 @@ enum ImportSymbol {
 fn resolve_import_package(
     output: &mut Vec<(Vec<String>, ImportSymbol, Span)>,
     mut package_segments: Vec<String>,
-    package_type: &PackageType,
+    package_or_packages: &PackageOrPackages,
 ) {
-    match package_type {
-        PackageType::Package(package) => {
+    match package_or_packages {
+        PackageOrPackages::Package(package) => {
             package_segments.push(package.name.name.clone());
             resolve_import_package_access(output, package_segments, &package.access);
         }
-        PackageType::Packages(packages) => {
+        PackageOrPackages::Packages(packages) => {
             package_segments.push(packages.name.name.clone());
             for access in packages.accesses.clone() {
                 resolve_import_package_access(output, package_segments.clone(), &access);
@@ -100,7 +100,11 @@ fn resolve_import_package_access(
             output.push((package_segments, ImportSymbol::All, span.clone()));
         }
         PackageAccess::SubPackage(subpackage) => {
-            resolve_import_package(output, package_segments, &PackageType::Package(*(*subpackage).clone()));
+            resolve_import_package(
+                output,
+                package_segments,
+                &PackageOrPackages::Package(*(*subpackage).clone()),
+            );
         }
         PackageAccess::Symbol(symbol) => {
             let span = symbol.symbol.span.clone();
@@ -136,7 +140,7 @@ impl InternalProgram {
         // Recursively extract imported symbols.
         let mut imported_symbols: Vec<(Vec<String>, ImportSymbol, Span)> = vec![];
         for import in program.imports.iter() {
-            resolve_import_package(&mut imported_symbols, vec![], &import.package_type);
+            resolve_import_package(&mut imported_symbols, vec![], &import.package_or_packages);
         }
 
         // Create package list.
@@ -393,7 +397,7 @@ pub fn reform_ast(program: &Program) -> leo_ast::Program {
         imports: core_programs
             .iter()
             .map(|(module, _)| leo_ast::ImportStatement {
-                package_type: leo_ast::PackageType::Package(leo_ast::Package {
+                package_or_packages: leo_ast::PackageOrPackages::Package(leo_ast::Package {
                     name: Identifier::new(module.clone()),
                     access: leo_ast::PackageAccess::Star(Span::default()),
                     span: Default::default(),

diff --git a/ast/src/imports/import.rs b/ast/src/imports/import.rs
@@ -14,7 +14,7 @@
 // You should have received a copy of the GNU General Public License
 // along with the Leo library. If not, see <https://www.gnu.org/licenses/>.
 
-use crate::{PackageType, Span};
+use crate::{PackageOrPackages, Span};
 use leo_grammar::imports::Import as GrammarImport;
 
 use serde::{Deserialize, Serialize};
@@ -23,7 +23,7 @@ use std::fmt;
 /// Represents an import statement in a Leo program.
 #[derive(Clone, Eq, PartialEq, Serialize, Deserialize)]
 pub struct ImportStatement {
-    pub package_type: PackageType,
+    pub package_or_packages: PackageOrPackages,
     pub span: Span,
 }
 
@@ -32,25 +32,25 @@ impl ImportStatement {
     /// Returns the the package file name of the self import statement.
     ///
     pub fn get_file_name(&self) -> &str {
-        match self.package_type {
-            PackageType::Package(ref package) => &package.name.name,
-            PackageType::Packages(ref packages) => &packages.name.name,
+        match self.package_or_packages {
+            PackageOrPackages::Package(ref package) => &package.name.name,
+            PackageOrPackages::Packages(ref packages) => &packages.name.name,
         }
     }
 }
 
 impl<'ast> From<GrammarImport<'ast>> for ImportStatement {
     fn from(import: GrammarImport<'ast>) -> Self {
         ImportStatement {
-            package_type: PackageType::from(import.package_type),
+            package_or_packages: PackageOrPackages::from(import.package_or_packages),
             span: Span::from(import.span),
         }
     }
 }
 
 impl ImportStatement {
     fn format(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        write!(f, "import {};", self.package_type)
+        write!(f, "import {};", self.package_or_packages)
     }
 }
 

diff --git a/ast/src/imports/mod.rs b/ast/src/imports/mod.rs
@@ -26,8 +26,8 @@ pub use package::*;
 pub mod packages;
 pub use packages::*;
 
-pub mod package_type;
-pub use package_type::*;
+pub mod package_or_packages;
+pub use package_or_packages::*;
 
 pub mod package_access;
 pub use package_access::*;
diff --git a/ast/src/imports/package_type.rs → ast/src/imports/package_or_packages.rs b/ast/src/imports/package_type.rs → ast/src/imports/package_or_packages.rs
@@ -15,31 +15,31 @@
 // along with the Leo library. If not, see <https://www.gnu.org/licenses/>.
 
 use crate::{Package, Packages};
-use leo_grammar::imports::PackageType as GrammarPackageType;
+use leo_grammar::imports::PackageOrPackages as GrammarPackageOrPackages;
 
 use serde::{Deserialize, Serialize};
 use std::fmt;
 
 #[derive(Clone, Eq, Hash, PartialEq, Serialize, Deserialize)]
-pub enum PackageType {
+pub enum PackageOrPackages {
     Package(Package),
     Packages(Packages),
 }
 
-impl<'ast> From<GrammarPackageType<'ast>> for PackageType {
-    fn from(package_type: GrammarPackageType<'ast>) -> Self {
-        match package_type {
-            GrammarPackageType::Package(package) => PackageType::Package(Package::from(package)),
-            GrammarPackageType::Packages(packages) => PackageType::Packages(Packages::from(packages)),
+impl<'ast> From<GrammarPackageOrPackages<'ast>> for PackageOrPackages {
+    fn from(package_or_packages: GrammarPackageOrPackages<'ast>) -> Self {
+        match package_or_packages {
+            GrammarPackageOrPackages::Package(package) => PackageOrPackages::Package(Package::from(package)),
+            GrammarPackageOrPackages::Packages(packages) => PackageOrPackages::Packages(Packages::from(packages)),
         }
     }
 }
 
-impl PackageType {
+impl PackageOrPackages {
     fn format(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
-            PackageType::Package(ref package) => write!(f, "{}", package),
-            PackageType::Packages(ref packages) => {
+            PackageOrPackages::Package(ref package) => write!(f, "{}", package),
+            PackageOrPackages::Packages(ref packages) => {
                 write!(f, "(")?;
                 for (i, access) in packages.accesses.iter().enumerate() {
                     write!(f, "{}", access)?;
@@ -53,13 +53,13 @@ impl PackageType {
     }
 }
 
-impl fmt::Debug for PackageType {
+impl fmt::Debug for PackageOrPackages {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         self.format(f)
     }
 }
 
-impl fmt::Display for PackageType {
+impl fmt::Display for PackageOrPackages {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         self.format(f)
     }

diff --git a/grammar/src/imports/import.rs b/grammar/src/imports/import.rs
@@ -14,7 +14,7 @@
 // You should have received a copy of the GNU General Public License
 // along with the Leo library. If not, see <https://www.gnu.org/licenses/>.
 
-use crate::{ast::Rule, common::LineEnd, imports::PackageType, SpanDef};
+use crate::{ast::Rule, common::LineEnd, imports::PackageOrPackages, SpanDef};
 
 use pest::Span;
 use pest_ast::FromPest;
@@ -23,7 +23,7 @@ use serde::Serialize;
 #[derive(Clone, Debug, FromPest, PartialEq, Serialize)]
 #[pest_ast(rule(Rule::import))]
 pub struct Import<'ast> {
-    pub package_type: PackageType<'ast>,
+    pub package_or_packages: PackageOrPackages<'ast>,
     pub line_end: LineEnd,
     #[pest_ast(outer())]
     #[serde(with = "SpanDef")]

diff --git a/grammar/src/imports/mod.rs b/grammar/src/imports/mod.rs
@@ -26,8 +26,8 @@ pub use package::*;
 pub mod packages;
 pub use packages::*;
 
-pub mod package_type;
-pub use package_type::*;
+pub mod package_or_packages;
+pub use package_or_packages::*;
 
 pub mod package_access;
 pub use package_access::*;

diff --git a/grammar/src/imports/package_type.rs → grammar/src/imports/package_or_packages.rs b/grammar/src/imports/package_type.rs → grammar/src/imports/package_or_packages.rs
@@ -23,8 +23,8 @@ use pest_ast::FromPest;
 use serde::Serialize;
 
 #[derive(Clone, Debug, FromPest, PartialEq, Serialize)]
-#[pest_ast(rule(Rule::package_type))]
-pub enum PackageType<'ast> {
+#[pest_ast(rule(Rule::package_or_packages))]
+pub enum PackageOrPackages<'ast> {
     Package(Package<'ast>),
     Packages(Packages<'ast>),
 }
diff --git a/grammar/src/leo.pest b/grammar/src/leo.pest
@@ -454,13 +454,13 @@ input_tuple = _{ "(" ~ (input ~ ("," ~ input)* ~ ","?)? ~ ")"}
 /// Imports
 
 // Declared in imports/import.rs
-import = { "import " ~ package_type ~ LINE_END}
+import = { "import " ~ package_or_packages ~ LINE_END}
 
 // Declared in imports/package_name.rs
 package_name = @{ (ASCII_ALPHA_LOWER | ASCII_DIGIT)+ ~ ( "-" ~ (ASCII_ALPHA_LOWER | ASCII_DIGIT)+)* }
 
-// Declared in imports/package_type.rs
-package_type = {
+// Declared in imports/package_or_packages.rs
+package_or_packages = {
     packages
     | package
 }