Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 001-initial-strings.md #983

Merged
merged 1 commit into from May 27, 2021
Merged

Conversation

bendyarm
Copy link
Contributor

Add references to Rust documentation on character literal syntax and string literal syntax. Remove example of empty string. Other miscellaneous clarifications.

Motivation

I agreed to do this at the last compiler team meeting.

Add references to Rust documentation on character literal syntax and string literal syntax.  Remove example of empty string.
@bendyarm bendyarm requested review from damirka and gluax May 26, 2021 16:15
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #983 (37e9e35) into master (7aa3fa3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         429      429           
  Lines       17170    17170           
=======================================
+ Hits        12873    12874    +1     
+ Misses       4297     4296    -1     
Impacted Files Coverage Δ
ast/src/statements/expression.rs 44.44% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa3fa3...37e9e35. Read the comment docs.

Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@acoglio acoglio merged commit b1e15f4 into master May 27, 2021
@acoglio acoglio deleted the add-rust-string-syntax-refs branch May 27, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants