New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Make --node optional to ensure it has an influence even when using --dev; renames --storage_path
to --storage
#3189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤓
Made an issue for the flaky test, which was already flaky before this PR: #3190 |
|
Note behavior only changes if you use both
Both devnet and canary do not use
They do not use
They do not use
I ran |
Tested on |
--storage_path
to storage
^ This commit renames |
--storage_path
to storage
--storage_path
to --storage
--storage_path
to --storage
--storage_path
to --storage
Motivation
Previously, when using
--dev
, the node ports would automatically be incremented alongside the the dev index. This makes it hard to indicate--peers
on other machines, as you'll need to know the dev index / port number before it works. This design is similar to the--bft
flag.This PR also renames
--storage_path
to--storage
in the CLIstart
command.Test Plan
This only changes a node's behaviour when both
--node
and--dev
are used.Tested manually locally and on aws.
Related PRs
Needed because we're testing: #3163