Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Need a way to NOT change REST port number when --dev parameter is specified #3220

Open
robwafle opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@robwafle
Copy link

robwafle commented Apr 16, 2024

馃殌 Feature

Need a way to NOT change REST port number when --dev parameter is specified

Motivation

This will allow clients to be in a load balancer similar to a production environment where the load balancer points to all 30 clients (e.g. 3 clients for each of the 10 validators). We need development testing environments to match production as closely as possible, and without this we can't have a dev environment that closely resembles production.

Implementation

Hopefully, this is only logic to parse the parameter and one if statement wrapping a small amount of logic that actually doesn't happen in production networks. (when --dev parameter is NOT specified )

I believe the +dev on this line is part of what would have to be made conditional:
https://github.com/AleoHQ/snarkOS/blob/mainnet-staging/cli/src/commands/start.rs#L328

@robwafle robwafle added the feature New feature or request label Apr 16, 2024
@robwafle robwafle changed the title [Feature] Do not change REST port number when --dev-no-dynamic-ports parameter is specified [Feature] Do not change REST port number when --dev-no-dynamic-ports switch is specified Apr 17, 2024
@vicsn
Copy link
Contributor

vicsn commented Apr 17, 2024

See for a similar or the same issue: https://github.com/AleoHQ/snarkOS/pull/3189

@robwafle robwafle changed the title [Feature] Do not change REST port number when --dev-no-dynamic-ports switch is specified [Feature] Need a way to NOT change REST port number when --dev parameter is specified Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants