Fix test for integer division #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Oct 20, 2022
ljedrz
reviewed
Oct 20, 2022
|
@d0cd can we add an explicit test case to check for the failure case that was detected? |
ljedrz
reviewed
Oct 25, 2022
ljedrz
reviewed
Oct 25, 2022
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Signed-off-by: d0cd <pranavsaig@gmail.com>
d0cd
force-pushed
the
fix/div-instruction-test
branch
from
bfa1da1
to
0534fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
panic_on_haltcondition for the integer division instruction.