[zksecurity 00 01] Use committing encryption to commit to inputs and outputs #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
changed the title
vicsn
force-pushed
the
user_committing_encryption
branch
from
48a147f
to
e0a8c4d
Compare
howardwu
approved these changes
Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were not properly committing to the inputs and outputs of our Requests and Responses.
The issue at hand only arises at the boundary of circuits calling other circuits. So the
check_input_ids(...)andprocess_outputs_from_callback(...)in call/mod.rs is where this issue appears the first time. We now publicly witnesstcmof the callee in the caller circuits.Sidenote: we were already publicly witnessing function's own request.tcm.
Test Plan
Locally the tests succeed.