Moving height, round,solutions, and transactions to bft for clients #3210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, we only track height, round, solutions and transactions in consensus, and not in the
node/bft
CoreLedgerService
, therefore we cannot track what height clients are at. This PR moves those metrics into theCoreLedgerService
.Also removed the numTransmissions metric, as you can just
sum
the numTransactions and numSolutions in the end analytics service (metrics/prometheus or visualization/Grafana) if needed.Test Plan
These graphs show where I add 5 clients to the network.