feat: dim logs on shutdown #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joske
force-pushed
the
feat/dim_logs
branch
3 times, most recently
from
a325a07
to
92592ca
Compare
There was a problem hiding this comment.
Thanks for this @joske, I'll try to run this later today. Is it possible to add an explicit message in the terminal to wait for shutdown to complete?
joske
force-pushed
the
feat/dim_logs
branch
2 times, most recently
from
8003421
to
489bdae
Compare
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
ljedrz
reviewed
Apr 30, 2024
joske
force-pushed
the
feat/dim_logs
branch
2 times, most recently
from
15b11b7
to
de654b3
Compare
|
CircleCi is having a moment, that failure is unrelated to the changes. Let's try rerunning a little later. |
niklaslong
approved these changes
Apr 30, 2024
iamalwaysuncomfortable
requested changes
Apr 30, 2024
There was a problem hiding this comment.
The initial message needs to be a bit more clear and should probably be highlighted or bolded. I've included a suggestion for wording.
Also:
- During shutdown, are any further SIGINT/SIGHUP/SIGTERM signals caught & ignored so that graceful shutdown can continue?
- I think this work is a good start, but in a follow-on PR we should maybe consider launching a display which displays graceful shutdown warnings more prominently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements log dimming (if running in TTY mode) on shutdown (CTRL-C handler).
I've moved the shutdown flag earlier in the startup so it can be reused for the log dimming too.
There is some performance impact as it needs to check the boolean for every log event (and an extra method call).