[Logs] Update log levels for safe behavior #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
changed the title
howardwu
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the log messages, primary to de-escalate
WARNlogs that should realistically be safe and be on theDEBUGlevel.Examples of such logs are:
WARN Cannot store a signature from '{peer_ip}' - This batch was already certifiedWARN Cannot sign a batch from '{peer_ip}' - Batch for round {round} already exists in storage (gc = {gc_round})WARN Primary is safely skipping (round {round} was already certified)These do not need to be at a
WARNlevel as are alarming to node operators, but they demonstrate safe behavior.