[Optimize] Store pending certificates to proposal cache file #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
reviewed
May 9, 2024
| @@ -144,15 +159,20 @@ impl<N: Network> FromBytes for ProposalCache<N> { | |||
| }; | |||
| // Deserialize `signed_proposals`. | |||
| let signed_proposals = SignedProposals::read_le(&mut reader)?; | |||
| // Read the number of pending certificates. | |||
| let num_certificates = u32::read_le(&mut reader)?; | |||
There was a problem hiding this comment.
We need to safety check this number so it does not overallocate.
There was a problem hiding this comment.
Resolved in AleoHQ@7ed91da
howardwu
reviewed
May 9, 2024
Comment on lines
+336
to
+350
| for (_, certificates_for_round) in rounds.clone().sorted_by(|a, _, b, _| a.cmp(b)) { | ||
| // Iterate over the certificates for the round. | ||
| for (certificate_id, _, _) in certificates_for_round { | ||
| // Skip the certificate if it already exists in the ledger. | ||
| if self.ledger.contains_certificate(&certificate_id).unwrap_or(false) { | ||
| continue; | ||
| } | ||
|
|
||
| // Add the certificate to the pending certificates. | ||
| match certificates.get(&certificate_id).cloned() { | ||
| Some(certificate) => pending_certificates.insert(certificate), | ||
| None => continue, | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
@ljedrz can you look into using cfg_iter and/or cfg_sorted_by to rayonify (conditionally with feature = 'serial')?
There was a problem hiding this comment.
Can you implement the perf improvement here @ljedrz
There was a problem hiding this comment.
The snarkOS branch is ready, just needs https://github.com/AleoHQ/snarkVM/pull/2450 to be merged.
howardwu
approved these changes
May 9, 2024
howardwu
reviewed
May 9, 2024
| *self.propose_lock.lock().await = latest_certificate_round; | ||
|
|
||
| // Update the storage with the pending certificates. | ||
| for certificate in pending_certificates { |
There was a problem hiding this comment.
Can this be sped up @ljedrz ?
There was a problem hiding this comment.
I don't see anything obvious, but I'll investigate it further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is an extension of https://github.com/AleoHQ/snarkOS/pull/3239 that addresses https://github.com/AleoHQ/snarkOS/issues/3171.
This PR adds to the functionality of the
ProposalCacheby adding pending certificates (that have not yet been included in ledger) to the list of attributes to store to file.This should increase the robustness of reboots because nodes should now not need to rely on
PrimaryPingsto catch up to other peers in a reboot scenario. Initial testing has observed successful restarts (in the honest case) for any number of validators (including scenarios of more thanf+1validators rebooting).Test Plan
Burn-in tests and additional reboot testing needs to be done to ensure robustness of this change.
Related PRs
Extension of https://github.com/AleoHQ/snarkOS/pull/3239