Revert "Avoid unnecessary calculations in propose_batch" #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should I resubmit a PR to address this issue? |
Meshiest
approved these changes
May 24, 2024
apruden2008
approved these changes
May 24, 2024
apruden2008
deleted the
revert-3265-perf/unnecessary_calculations_in_propose_batch
branch
yes please @elderhammer - just target the |
Done. #3275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3265
Sorry about that @elderhammer - that PR was accidentally merged into the wrong branch. It should have targeted
mainnet-stagingso that we can test before merging intomainnet.Thank you for your contribution!