Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZKS-04] Fixes the maximum transmissions per batch, increases the transactions per block #2198

Merged
merged 12 commits into from
Nov 30, 2023
Merged

[ZKS-04] Fixes the maximum transmissions per batch, increases the transactions per block #2198

merged 12 commits into from
Nov 30, 2023

Conversation

howardwu
Copy link
Contributor

@howardwu howardwu commented Nov 25, 2023 •
edited by raychu86

Motivation

  • Reduces the maximum transmissions per batch.
    • This limit is set to 50 as part of safety measures to prevent DoS attacks.
    • This limit can be increased in the future as performance improves. Alternatively, the rate of block production can be sped up to compensate for the limit set here.
  • Increases the number of transactions per block to 2^20 to reflect subdag safety (overflow) requirements

The sister PR in snarkOS can be found here: https://github.com/AleoHQ/snarkOS/pull/2869.

Audit Finding: [zksecurity 04] Garbage Collection Can Block Commits From Happening

@howardwu howardwu changed the title Reduces the maximum transmissions per batch Reduces the maximum transmissions per batch, increases the transactions per block Nov 25, 2023
@howardwu howardwu changed the base branch from testnet3 to mainnet November 25, 2023 22:44
@howardwu howardwu mentioned this pull request Nov 25, 2023
Draft
@howardwu howardwu changed the title Reduces the maximum transmissions per batch, increases the transactions per block Fixes the maximum transmissions per batch, increases the transactions per block Nov 25, 2023
@howardwu howardwu marked this pull request as ready for review November 26, 2023 00:25
@howardwu howardwu mentioned this pull request Nov 26, 2023
Merged
@howardwu howardwu merged commit 6fb21fb into mainnet Nov 30, 2023
0 of 54 checks passed
@howardwu howardwu deleted the feat/max-transmissions-limit branch November 30, 2023 17:50
@raychu86 raychu86 changed the title Fixes the maximum transmissions per batch, increases the transactions per block [zksecurity 04] Fixes the maximum transmissions per batch, increases the transactions per block Feb 12, 2024
@raychu86 raychu86 changed the title [zksecurity 04] Fixes the maximum transmissions per batch, increases the transactions per block [ZKS-04] Fixes the maximum transmissions per batch, increases the transactions per block Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@howardwu @raychu86