[HackerOne-2300725] Limit the number of allowed constraints for deployments #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
ljedrz
reviewed
Jan 9, 2024
vicsn
commented
Jan 10, 2024
This was referenced Jan 10, 2024
vicsn
changed the title
vicsn
changed the title
|
@evan-schott can you help finish the two tests in 01b95d2 and look at fixing any broken CI tests? We can discuss further in person. |
I will investigate |
|
Is there a reason more CI tests are failing? Do we need to resample anything? |
…thesis that randomizes vars
vicsn
commented
Feb 2, 2024
vicsn
commented
Feb 2, 2024
|
LGTM! |
howardwu
reviewed
Feb 9, 2024
Comment on lines
+385
to
+389
| // If in 'CheckDeployment' mode, set the expected constraint limit. | ||
| if let CallStack::CheckDeployment(_, _, _, constraint_limit) = ®isters.call_stack() { | ||
| A::set_constraint_limit(*constraint_limit); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not convinced this logic is necessary.
When triggering call, no logic above this resets the constraint limit AFAIK.
howardwu
approved these changes
Feb 9, 2024
raychu86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Large deployments may take a lot of time to synthesize, so as an initial stopgap we can limit their size, as measurement by the number of constraints.
Note that the current approach panics on failure, but because check_transaction_basic is called from snarkOS in a tokio task, this panic is gracefully handled. Returning a
Resultwould cascade to 100 other functions using theCircuitapi.Test Plan
Related PRs
https://github.com/AleoHQ/snarkOS/pull/2961