[Fix] Store the aborted solution IDs in blocks #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
changed the title
howardwu
approved these changes
Jan 20, 2024
raychu86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to how we are storing the aborted transaction ids in each block, we must do the same for the aborted solutions ids. This will allow nodes that are syncing up via the BFT protocol to accurately place and handle the otherwise missing solution transmissions.
Each block will now have a new
aborted_solution_idsfield that stores a list of the aborted solution ids (Vec<PuzzleCommitment<N>>).In addition, the BlockStorage now has 2 additional maps to track these aborted solutions:
block hashto[aborted solution ID]puzzle commitmenttoblock height