Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the OuterCircuit in DPC #301

Merged
merged 11 commits into from
Jul 26, 2021
Merged

Conversation

weikengchen
Copy link
Contributor

@weikengchen weikengchen commented Jul 25, 2021

Motivation

This PR would go to #300. The PR unifies the OuterCircuit in DPC.

Test Plan

Will wait for the CI for the results. Keys for the outer circuit need to be resampled.

Related PRs

This is part of #300.

@weikengchen
Copy link
Contributor Author

Parameters need to be resampled.

A local resampling and integration tests have been done.

  • testnet1 cannot succeed because NoopProgramCircuit always point to testnet2's parameters, which requires a separate fix in Unify DPC programs #300. One needs to decide where to put the NoopProgram parameters (in DPC parameters? though NoopProgram is for test purposes).
  • testnet2 passes.

It is ready for review and merge.

@weikengchen weikengchen marked this pull request as ready for review July 25, 2021 23:48
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small suggestions.

@weikengchen weikengchen mentioned this pull request Jul 26, 2021
@weikengchen
Copy link
Contributor Author

Left a few small suggestions.

Thanks. The issues have been resolved.

@weikengchen
Copy link
Contributor Author

The recent update in this PR solves a few remaining issues in #300:

  • allow testnet1 and testnet2 to load different parameters for Program SNARK, using the NETWORK_ID
  • SRS has been refactored so that it does not cause an overhead of to_bytes_le
  • Name change for URS in Marlin.

It is ready to be merged into #300 and then updated with a parameter resampling.

@howardwu
Copy link
Contributor

LGTM. Worth calling out that this PR also introduces ToBits functionality for structs that implement the Field trait, thank you @weikengchen!

For the 3 failing CI, 2 are due to resampling parameter requirements, and 1 is a clippy failure from PR 300, these will get resolved in PR #300.

@howardwu howardwu added the staging Staging label Jul 26, 2021
@howardwu howardwu merged commit 3b24338 into refactor/dpc-programs Jul 26, 2021
@howardwu howardwu deleted the feat/dpc-unify branch July 26, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants