-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the OuterCircuit in DPC #301
Conversation
Parameters need to be resampled. A local resampling and integration tests have been done.
It is ready for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small suggestions.
Thanks. The issues have been resolved. |
The recent update in this PR solves a few remaining issues in #300:
It is ready to be merged into #300 and then updated with a parameter resampling. |
LGTM. Worth calling out that this PR also introduces For the 3 failing CI, 2 are due to resampling parameter requirements, and 1 is a clippy failure from PR 300, these will get resolved in PR #300. |
Motivation
This PR would go to #300. The PR unifies the OuterCircuit in DPC.
Test Plan
Will wait for the CI for the results. Keys for the outer circuit need to be resampled.
Related PRs
This is part of #300.