Fix #[ts(skip)] in newtype variants
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyxCode
commented
Feb 10, 2024
Comment on lines
120
to
133
| if skip { | ||
| quote!(format!("{{ \"{}\": \"{}\" }}", #tag, #name)) | ||
| } else { | ||
| let ty = match (type_override, type_as) { | ||
| (Some(_), Some(_)) => syn_err!("`type` is not compatible with `as`"), | ||
| (Some(type_override), None) => quote! { #type_override }, | ||
| (None, Some(type_as)) => { | ||
| format_type(&syn::parse_str::<Type>(&type_as)?, dependencies, generics) | ||
| } | ||
| (None, None) => format_type(&unnamed.unnamed[0].ty, dependencies, generics), | ||
| }; | ||
|
|
||
| quote!(format!("{{ \"{}\": \"{}\", \"{}\": {} }}", #tag, #name, #content, #ty)) | ||
| } |
There was a problem hiding this comment.
@timephy This here was the issue: format_type was called outside of the if skip { .. }, adding the content to the dependencies even if the field was to be skipped.
There was a problem hiding this comment.
Hey :)
Great investigation! Thank you for the quick fix - highly appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.