Add '#[ts(bound)]' attribute #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyxCode
commented
Mar 14, 2024
There was a problem hiding this comment.
@WilsonGramer Looks good! Could you add docs for it (type doc of TS)?
macros/src/lib.rs
Outdated
Comment on lines
335
to
344
| let where_bound = bounds.map_or_else( | ||
| || { | ||
| let bounds = generate_where_clause(generics, dependencies); | ||
| quote! { #bounds } | ||
| }, | ||
| |bounds| { | ||
| let bounds = syn::parse_str::<TokenStream>(bounds).expect("malformed `bounds`"); | ||
| quote! { where #bounds } | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I think I'd prefer a match here. No problem if you prefer map_or_else, though.
|
Hey @WilsonGramer! I have made some changes to improve error locations and opened a PR to your fork (this PR has maintainer edits disabled), please check it out WilsonGramer#1 |
Parse string into WherePredicate to improve errors
|
@NyxCode I added the docs and merged in @escritorio-gustavo's changes — let me know if anything else needs to be done! |
|
I'm happy with this, thanks! |
escritorio-gustavo
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.