Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location of rename_all errors #303

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix location of rename_all errors #303

merged 1 commit into from
Apr 9, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

Goal

After #298 errors in rename_all were pointing at the = token instead of the attribute value, this PR fixes that mistake

Changes

Changed parse_assign_inflection to get the correct Span

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@escritorio-gustavo escritorio-gustavo merged commit b9a4cca into main Apr 9, 2024
14 checks passed
@escritorio-gustavo escritorio-gustavo deleted the rename_all_error_location branch April 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@escritorio-gustavo