Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fix issue with absolute paths #323

Merged
merged 3 commits into from
Jun 4, 2024
Merged

bug: Fix issue with absolute paths #323

merged 3 commits into from
Jun 4, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo commented May 23, 2024 •
edited
Loading

Goal

Remove the absolute path check that tricks the absolute function
Closes #322
Closes #325

Changes

Removed an if statement in the absolute function that would returned the unaltered path

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@escritorio-gustavo escritorio-gustavo added the bug Something isn't working label May 27, 2024
@escritorio-gustavo escritorio-gustavo changed the title Fix issue with absolute paths bug: Fix issue with absolute paths May 27, 2024
NyxCode
NyxCode approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@NyxCode NyxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I feel a bit iffy about that part of the code base.

Could we come up with some tests (or at least one for the linked issue)?

@escritorio-gustavo
Copy link
Contributor Author

Could we come up with some tests (or at least one for the linked issue)?

I've added a CI test to trigger the incorrect behavior by running TS_RS_EXPORT_DIR=$(pwd)/output cargo test --no-default-features.
The use of pwd makes the path_bug test break

@escritorio-gustavo escritorio-gustavo mentioned this pull request Jun 4, 2024
Closed
@NyxCode
Copy link
Collaborator

NyxCode commented Jun 4, 2024

Awesome, thanks! Feel free to merge!

@escritorio-gustavo escritorio-gustavo merged commit be0349d into main Jun 4, 2024
16 checks passed
@escritorio-gustavo escritorio-gustavo deleted the absolute_path_bug branch June 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyxCode NyxCode NyxCode approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@escritorio-gustavo @NyxCode