Skip to content

Commit

Permalink
fixed leaked memory with change context to getApplicationContext()
Browse files Browse the repository at this point in the history
  • Loading branch information
@AlessandroLazzari
AlessandroLazzari committed Mar 2, 2015
1 parent 3064286 commit 6b63c3f
Showing 1 changed file with 147 additions and 152 deletions.
299 changes: 147 additions & 152 deletions src/com/money/manager/ex/dropbox/DropboxBrowserActivity.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,190 +49,185 @@
import java.util.List;

public class DropboxBrowserActivity extends BaseFragmentActivity {
ublic
static final String INTENT_DROBPOXFILE_PATH = "DropboxBrowserActivity:DropboxFile";

private static String mDropboxFile = null;
p
Override

public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
getSupportActionBar().setDisplayHomeAsUpEnabled(true);
FragmentManager fm = getSupportFragmentManager();
// intent
if (getIntent() != null && getIntent().getExtras().containsKey(INTENT_DROBPOXFILE_PATH)) {
mDropboxFile = getIntent().getExtras().getString(INTENT_DROBPOXFILE_PATH);
}
// attach fragment to activity
if (fm.findFragmentById(android.R.id.content) == null) {
if (fm.findFragmentByTag(DropboxBrowserFragment.class.getSimpleName()) == null) {
DropboxBrowserFragment fragment = new DropboxBrowserFragment();
fm.beginTransaction().add(android.R.id.content, fragment, DropboxBrowserFragment.class.getSimpleName()).commit();
public static class DropboxBrowserFragment extends BaseListFragment {
//Define EntryAdapter
private class EntryAdapter extends ArrayAdapter<Entry> {
private int mLayoutId;
private LayoutInflater mInflater;

public EntryAdapter(Context context, int resource) {
this(context, resource, new ArrayList<Entry>());
}
}
}

@
Override
public boolean onKeyUp(int keyCode, KeyEvent event) {
if (keyCode == KeyEvent.KEYCODE_BACK) {
DropboxBrowserFragment fragment = (DropboxBrowserFragment) getSupportFragmentManager().findFragmentByTag(DropboxBrowserFragment.class.getSimpleName());
if (fragment != null) {
return fragment.onKeyUp(keyCode, event);
public EntryAdapter(Context context, int resource, List<Entry> objects) {
super(context, resource, objects);
mLayoutId = resource;
mInflater = LayoutInflater.from(context);
}
}
return super.onKeyUp(keyCode, event);
}
}
@

public static class DropboxBrowserFragment extends BaseListFragment {
DropboxHelper mHelper;
EntryAdapter mAdapter;

@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
// take a instance
mHelper = DropboxHelper.getInstance(getActivity());
mAdapter = new EntryAdapter(getActivity(), R.layout.simple_list_item_multiple_choice_2);
// set adapter
setListAdapter(mAdapter);

setEmptyText(getString(R.string.dropbox_empty_folder));

registerForContextMenu(getListView());

getListView().setChoiceMode(ListView.CHOICE_MODE_SINGLE);
setListShown(false);

//check item
getListView().setOnItemClickListener(new OnItemClickListener() {

@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
CheckedTextView checkedTextView = (CheckedTextView) view.findViewById(android.R.id.text1);
checkedTextView.toggle();
getListView().setItemChecked(position, checkedTextView.isChecked());
((EntryAdapter) getListAdapter()).setNotifyOnChange(true);
public View getView(int position, View convertView, ViewGroup parent) {
if (convertView == null || Build.VERSION.SDK_INT < Build.VERSION_CODES.HONEYCOMB) {
Entry entry = getItem(position);
if (entry != null) {
convertView = mInflater.inflate(mLayoutId, parent, false);
CheckedTextView text1 = (CheckedTextView)convertView.findViewById(android.R.id.text1);
TextView text2 = (TextView)convertView.findViewById(android.R.id.text2);
text1.setText(entry.path);
text2.setText(getString(R.string.last_modified) + ": " + new SimpleDateFormat().format(RESTUtility.parseDate(entry.modified)));
}
}
//checked item
CheckedTextView text1 = (CheckedTextView)convertView.findViewById(android.R.id.text1);
text1.setChecked(getListView().getCheckedItemPosition() == position);

return convertView;
}
});

//set option menu
setHasOptionsMenu(true);
}

//take a entries
if (mAdapter.getCount() <= 0)
refreshEntries();
}
DropboxHelper mHelper;
EntryAdapter mAdapter;

public boolean onKeyUp(int keyCode, KeyEvent event) {
if (keyCode == KeyEvent.KEYCODE_BACK) setResultAndFinish();
return false;
}
@Override
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
// take a instance
mHelper = DropboxHelper.getInstance(getActivity());
mAdapter = new EntryAdapter(getActivity(), R.layout.simple_list_item_multiple_choice_2);
// set adapter
setListAdapter(mAdapter);

setEmptyText(getString(R.string.dropbox_empty_folder));

registerForContextMenu(getListView());

getListView().setChoiceMode(ListView.CHOICE_MODE_SINGLE);
setListShown(false);

//check item
getListView().setOnItemClickListener(new OnItemClickListener() {

@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
CheckedTextView checkedTextView = (CheckedTextView)view.findViewById(android.R.id.text1);
checkedTextView.toggle();
getListView().setItemChecked(position, checkedTextView.isChecked());
((EntryAdapter)getListAdapter()).setNotifyOnChange(true);
}
});

@Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
super.onCreateOptionsMenu(menu, inflater);
inflater.inflate(R.menu.menu_dropbox_browser_activity, menu);
}
//set option menu
setHasOptionsMenu(true);

@Override
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case android.R.id.home:
setResultAndFinish();
return true;
case R.id.menu_refresh:
//take a entries
if (mAdapter.getCount() <= 0)
refreshEntries();
return true;
default:
return super.onOptionsItemSelected(item);
}
}

public void setResultAndFinish() {
Intent result = new Intent();
if (getListView().getCheckedItemPosition() == ListView.INVALID_POSITION) {
result.putExtra(INTENT_DROBPOXFILE_PATH, (String) null);
} else {
// set result and exit
result.putExtra(INTENT_DROBPOXFILE_PATH, mAdapter.getItem(getListView().getCheckedItemPosition()).path);
public boolean onKeyUp(int keyCode, KeyEvent event) {
if (keyCode == KeyEvent.KEYCODE_BACK) setResultAndFinish();
return false;
}
getActivity().setResult(RESULT_OK, result);
// exit
getActivity().finish();
}

private void refreshEntries() {
mHelper.getEntries(new OnGetEntries() {
@Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
super.onCreateOptionsMenu(menu, inflater);
inflater.inflate(R.menu.menu_dropbox_browser_activity, menu);
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case android.R.id.home:
setResultAndFinish();
return true;
case R.id.menu_refresh:
refreshEntries();
return true;
default:
return super.onOptionsItemSelected(item);
}
}

public void onStarting() {
setListShown(false);
mAdapter.clear();
mAdapter.setNotifyOnChange(true);
public void setResultAndFinish() {
Intent result = new Intent();
if (getListView().getCheckedItemPosition() == ListView.INVALID_POSITION) {
result.putExtra(INTENT_DROBPOXFILE_PATH, (String)null);
} else {
// set result and exit
result.putExtra(INTENT_DROBPOXFILE_PATH, mAdapter.getItem(getListView().getCheckedItemPosition()).path);
}
getActivity().setResult(RESULT_OK, result);
// exit
getActivity().finish();
}

public void onFinished(List<Entry> result) {
if (isVisible()) {
if (result != null) {
for (int i = 0; i < result.size(); i++) {
if (result.get(i).path.toLowerCase().endsWith(".mmb")) {
mAdapter.add(result.get(i));
//check if file is same pass from intent
if (getListView().getCheckedItemPosition() == ListView.INVALID_POSITION && result.get(i).path.equals(mDropboxFile)) {
getListView().setItemChecked(mAdapter.getCount() - 1, true);
private void refreshEntries() {
mHelper.getEntries(new OnGetEntries() {

public void onStarting() {
setListShown(false);
mAdapter.clear();
mAdapter.setNotifyOnChange(true);
}

public void onFinished(List<Entry> result) {
if (isVisible()) {
if (result != null) {
for(int i = 0; i < result.size(); i ++) {
if (result.get(i).path.toLowerCase().endsWith(".mmb")) {
mAdapter.add(result.get(i));
//check if file is same pass from intent
if (getListView().getCheckedItemPosition() == ListView.INVALID_POSITION && result.get(i).path.equals(mDropboxFile)) {
getListView().setItemChecked(mAdapter.getCount() - 1, true);
}
}
}
}
mAdapter.setNotifyOnChange(true);
setListShown(true);
}
mAdapter.setNotifyOnChange(true);
setListShown(true);
}
}
});
}
});
}

@Override
public String getSubTitle() {
return null;
@Override
public String getSubTitle() {
return null;
}
}

//Define EntryAdapter
private class EntryAdapter extends ArrayAdapter<Entry> {
private int mLayoutId;
private LayoutInflater mInflater;
public static final String INTENT_DROBPOXFILE_PATH = "DropboxBrowserActivity:DropboxFile";
private static String mDropboxFile = null;

public EntryAdapter(Context context, int resource) {
this(context, resource, new ArrayList<Entry>());
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
getSupportActionBar().setDisplayHomeAsUpEnabled(true);
FragmentManager fm = getSupportFragmentManager();
// intent
if (getIntent() != null && getIntent().getExtras().containsKey(INTENT_DROBPOXFILE_PATH)) {
mDropboxFile = getIntent().getExtras().getString(INTENT_DROBPOXFILE_PATH);
}

public EntryAdapter(Context context, int resource, List<Entry> objects) {
super(context, resource, objects);
mLayoutId = resource;
mInflater = LayoutInflater.from(context);
// attach fragment to activity
if (fm.findFragmentById(android.R.id.content) == null) {
if (fm.findFragmentByTag(DropboxBrowserFragment.class.getSimpleName()) == null) {
DropboxBrowserFragment fragment = new DropboxBrowserFragment();
fm.beginTransaction().add(android.R.id.content, fragment, DropboxBrowserFragment.class.getSimpleName()).commit();
}
}
}


@Override
public View getView(int position, View convertView, ViewGroup parent) {
if (convertView == null || Build.VERSION.SDK_INT < Build.VERSION_CODES.HONEYCOMB) {
Entry entry = getItem(position);
if (entry != null) {
convertView = mInflater.inflate(mLayoutId, parent, false);
CheckedTextView text1 = (CheckedTextView) convertView.findViewById(android.R.id.text1);
TextView text2 = (TextView) convertView.findViewById(android.R.id.text2);
text1.setText(entry.path);
text2.setText(getString(R.string.last_modified) + ": " + new SimpleDateFormat().format(RESTUtility.parseDate(entry.modified)));
}
@Override
public boolean onKeyUp(int keyCode, KeyEvent event) {
if (keyCode == KeyEvent.KEYCODE_BACK) {
DropboxBrowserFragment fragment = (DropboxBrowserFragment)getSupportFragmentManager().findFragmentByTag(DropboxBrowserFragment.class.getSimpleName());
if (fragment != null) {
return fragment.onKeyUp(keyCode, event);
}
//checked item
CheckedTextView text1 = (CheckedTextView) convertView.findViewById(android.R.id.text1);
text1.setChecked(getListView().getCheckedItemPosition() == position);

return convertView;
}

return super.onKeyUp(keyCode, event);
}
}
}

0 comments on commit 6b63c3f

Please sign in to comment.