Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn trainer class from Climate-Learing into all-purpose ML model class #5

Open
6 tasks
georgemilosh opened this issue Jul 27, 2023 · 3 comments
Open
6 tasks
Assignees
Labels
enhancement New feature or request

Comments

@georgemilosh
Copy link
Collaborator

I think that trainer class can be made more convenient and useful for more people. The most convenient feature that could be helpful in many applications is how hyperparameters are treated and automatic folders spawned with config.json and runs.jsonfiles. The issue is that Climate-Learning is too bulky and probably hard to understand for most people. To get more adopters simpler class would be preferred. This is not a easy thing to do because it depends heavily on other functions in Learn2_new.py of Climate-Learning/PLASIM. So here is a set of desired features and steps:

  • The class should be useful for anyone doing a parametric study and could be later inherited for downstream tasks
  • Check that similar class does not already exist somewhere on GitHub. Also consider writing it from scratch.
  • Trainer class stops being associated with a specific tasks of Climate-Learning: write a general class that has nothing to do with operations such as balancing, masking etc
  • Ideally it would not depend on whether the user chooses to work with tensorflow or pytorch
  • Make sure that the routines are as simple as possible. Basically try to reduce complexity of the code while prioritising utility
  • Good documentation is a plus.
@georgemilosh georgemilosh added the wontfix This will not be worked on label Jul 27, 2023
@AlessandroLovo
Copy link
Owner

Very good points! If I have time I'll work on it

@AlessandroLovo
Copy link
Owner

This might be sort of related

@georgemilosh
Copy link
Collaborator Author

Indeed. I am not sure they natively support k-fold cross-validation, although certainly a user can build on top of that.

@AlessandroLovo AlessandroLovo self-assigned this Jul 28, 2023
@AlessandroLovo AlessandroLovo added good first issue Good for newcomers enhancement New feature or request and removed wontfix This will not be worked on good first issue Good for newcomers labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants