Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indent/outdent functionality using Tab/Shift+Tab #923

Merged
merged 3 commits into from Feb 4, 2019
Merged

Add indent/outdent functionality using Tab/Shift+Tab #923

merged 3 commits into from Feb 4, 2019

Conversation

tyronx
Copy link
Contributor

@tyronx tyronx commented Feb 4, 2019

This works for me on Google chrome.

@tyronx tyronx mentioned this pull request Feb 4, 2019
Closed
Alex-D
Alex-D requested changes Feb 4, 2019
View reviewed changes
Copy link
Owner

@Alex-D Alex-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this override the native tab behaviour (go the the next focusable element) it's a breaking change and I can't merge this as is.

This can be enabled via a new option for sure :)

@tyronx
Copy link
Contributor Author

tyronx commented Feb 4, 2019 •
edited

Possible, but don't you think this should be the default behavior? All other major WYSIWYG editors do it like that as well.

[Edit:] Oh I guess you mean in terms of backwards compatibility. That makes more sense.

@tyronx
Copy link
Contributor Author

tyronx commented Feb 4, 2019

Option added and off by default.

@Alex-D Alex-D merged commit 0f37102 into Alex-D:develop Feb 4, 2019
@Alex-D
Copy link
Owner

Alex-D commented Feb 4, 2019

Thanks :)

@Daenero
Copy link

Daenero commented Mar 25, 2019

@Alex-D
Can you please build & publish latest version to npm?
Thanks!

@Alex-D
Copy link
Owner

Alex-D commented Mar 25, 2019

I will do that soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-D Alex-D Alex-D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyronx @Alex-D @Daenero