fix: consistency issue with getDocument on unfound doc #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match fs adapter comportment
Merged
Alex-Werner
added a commit
that referenced
this pull request
Aug 29, 2020
* chore: update mongo-objectid + exposed it (#16) * chore: updated mongo-objectid to 1.2.0 * feat: exposed ObjectID * test: added exposition test * chore: updated mongo-objectid to 1.2.1 * chore: bump dependencies to latest fix security issue. * fix: consistency issue with getDocument on unfound doc (#15) Match fs adapter comportment * chore(package): bump to 3.0.0 * fix: issue with lower fill factor than order for single element tree (#14) * fix: issue with lower fill factor than order for single element tree (#13) * fix(SBFRoot/findLowerThan): finding document on equal case for lte Specific case when order is bigger than actual size * style: formatting * test: add tests for tree with lower size than order Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com> * docs: docsify Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com>
Alex-Werner
added a commit
that referenced
this pull request
Aug 29, 2020
* chore: update mongo-objectid + exposed it (#16) * chore: updated mongo-objectid to 1.2.0 * feat: exposed ObjectID * test: added exposition test * chore: updated mongo-objectid to 1.2.1 * chore: bump dependencies to latest fix security issue. * fix: consistency issue with getDocument on unfound doc (#15) Match fs adapter comportment * chore(package): bump to 3.0.0 * fix: issue with lower fill factor than order for single element tree (#14) * fix: issue with lower fill factor than order for single element tree (#13) * fix(SBFRoot/findLowerThan): finding document on equal case for lte Specific case when order is bigger than actual size * style: formatting * test: add tests for tree with lower size than order Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com> * feat: add isReady method + remove waitFor deps (#18) * feat(SBTree): add isReady method * feat: moved waitFor to use isReady method * fix: fslock breaking change * docs: docsify documentation (#22) * chore: update mongo-objectid + exposed it (#16) * chore: updated mongo-objectid to 1.2.0 * feat: exposed ObjectID * test: added exposition test * chore: updated mongo-objectid to 1.2.1 * chore: bump dependencies to latest fix security issue. * fix: consistency issue with getDocument on unfound doc (#15) Match fs adapter comportment * chore(package): bump to 3.0.0 * fix: issue with lower fill factor than order for single element tree (#14) * fix: issue with lower fill factor than order for single element tree (#13) * fix(SBFRoot/findLowerThan): finding document on equal case for lte Specific case when order is bigger than actual size * style: formatting * test: add tests for tree with lower size than order Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com> * docs: docsify Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com> * tests!: reorganize tests + nested functional BREAKING: get document unfound returns null instead of {} * chore: added DS and nyc output to ignored entities * chore!: return single document as [] + split lodash module * chore: update dev deps * style: eslint fix * fix: handling on unfound field * feat!: remove single object as array * chore: add badges Co-authored-by: Anurag Vohra <53807480+anuragvohraec@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or implemented
When we require a document by it's ID that do not exist, with the MemoryAdapter, the response looks like :
While the FS adapter will return an empty object ({});.
What was done
Removed the
_idfield from return object of unfound document.How Has This Been Tested?
Using current test suite.
Notes
Checklist: