-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remove): adding ability to remove key #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Werner
force-pushed
the
feat/remove
branch
from
September 24, 2019 11:09
058fe35
to
2005a21
Compare
Moved into the internal github project management tracker
added test.utils for the expectAsyncException
As the feature dump all identifier, it made more sense to name it getAll instead of findAll
needed for deletion
Is part of breaking changes. This commit includes tests update
Still needed for FsAdapter
will return fillFactor, leafSize and order. Used by redistribute method
Also exported utils
Alex-Werner
force-pushed
the
feat/remove
branch
from
October 3, 2019 03:37
fde59aa
to
ef1963a
Compare
Alex-Werner
force-pushed
the
feat/remove
branch
from
October 3, 2019 22:27
58b90e5
to
6072fa5
Compare
Now root correctly hold data at starts in an identifiers array. Will make our test fails
Alex-Werner
force-pushed
the
feat/remove
branch
from
October 3, 2019 22:32
6072fa5
to
2f9f8f8
Compare
Also added snapshot.1.1 which use fixture instead of whole insertion
also Breaking : format of find is now {identifiers, keys}.
Warning : We lose in performance recently as we needed this change. We should think of some perf impr at some point
Alex-Werner
force-pushed
the
feat/remove
branch
2 times, most recently
from
October 8, 2019 10:23
ae517cf
to
28a4e14
Compare
Alex-Werner
force-pushed
the
feat/remove
branch
from
October 8, 2019 10:28
28a4e14
to
a18049f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or implemented
This feature bring removal ability to SBTree.
Due to the need of that feature for our early implementation. We also bring additional feature in that PR as-well as improved test coverage.
What was done
.getFillStatus
of a leaf..remove
for all types.mergeWithSiblings
..getLeft
and.getRight
helper for leaf.getAllInLeaf()
.findAll()
to.getAll()
Notes :
Result from the benchmark as ran by travis