Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impr: replace #9

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Impr: replace #9

merged 3 commits into from
Oct 26, 2019

Conversation

Alex-Werner
Copy link
Owner

Issue being fixed or implemented

Right now, to update a document, you have to delete it and insert the updated one.
This PR bring ability to replaceDocuments().

What was done

  • Added .replaceDocuments
  • Created constants for validTypes handling.
  • Added boolean as a valid type (we can handle it for insertion/finding as the others).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Alex-Werner Alex-Werner merged commit d50d63a into master Oct 26, 2019
@Alex-Werner Alex-Werner deleted the impr/replace branch October 26, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Alex-Werner