port to .net core 3 & .net standard #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that since no files are changed, the tests can remain the same |
|
i also suggest changing AppVeyor msbuild version to 15 to support PackageReference in project files |
|
I also updated DynamicExpresso.Core to v2.3.1 |
Alex141
reviewed
Mar 6, 2019
There was a problem hiding this comment.
thanks for PR, I have put several comments in commits and have overall comments:
1.) Unit tests should test library with .netcore3.0, so Tests project should also be ported
2.) I don't use AppVeyor so don't look at its fails :) but maybe i will use it in the near future
3.) .net core 3.0 is in preview stage, so it is not recommended to use it in production projects. I think that we can integrate changes after review, but I doubt whether to publish a package with it?
|
|
Ok, I propose following: 1.) Leave one project CalcBinding.csproj and WpfExample.csproj. 4.) It will allow us to build projects for .net4.0, 4.5 and .netcore3.0 with different dependencies 6.) About mstest in .netcore3.0 - it can be used, just type: |
That is why you need to have tests that check code on the latest preview version of net framework. If the behavior of the library will be different, then this should be taken into account. If a bug was found - notify. |
….0 by switching PackageReference of DynamicExpresso
|
ok so i managed to merge CalcBinding into 1 project, also you don't need to manually create nuget package, visual studio's pack command creates this package
i tested this by switching WpfExample project to .net 4.0 and it works well as for merging WpfExample.Core into WpfExample i am not really sure about this, since visual studio hasn't provided a designer for WPF on .net core 3 yet, and you must use vs 2019 to use the .net core 3 project, so i suggest to leave them as 2 separate projects for the time being until it's more stable for .net core 3 |
|
as for the tests, i created the project, but the build is failing because it can't find reference to wpf assemblies like version: build: test: |
|
Well done! I did not know that package can be created from visual studio :) About tests: I think that problem is in using incorrect Sdk, I left comment, try to test with other Sdk. |
Alex141
reviewed
Mar 8, 2019
bigworld12
changed the title
|
running tests on .net core now gives the following behavior i think these are due to how .net core changed their formatting system, check: https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-core-3-0#ieee-floating-point-improvements |
|
managed to solve most issues, but what the hell is this ??? |
|
ok for now, all tests are passing, but i don't like the breaking changes in floating point arithmetic in .net core, this will confuse many people used to .net framework |
|
@Alex141 think this is ready for a merge now 👍 |
|
oh, I read your hot correspondence with corefx, I also don't know about these changes in .net core. Ok, well done, that corrected all the tests, I can merge PR. Later I will publish new nuget package, thank you! |
AlexZinchenko
pushed a commit
that referenced
this pull request
Mar 13, 2019
|
I have commit some improvements to PR - ref and I was very surprised when MathTwoWayWithStaticPropertyTest() was failed in zTests.Core. It was expected 1d but real value was 0.999999999999999. Version of .net core is 3.0, I don't know, why it don't work on your machine and work in my. Maybe you know? |
|
let's keep discussion on the commit then. since this was merged, i will delete fork |
|
ok, I have published package 2.5.1 with these changes. May be you delete package https://www.nuget.org/packages/CalcBinding.Core/ ? |
|
@Alex141 done 👍 |
Closed
|
Guys, what about .NET Standard? |
|
@maurosampietro binding doesn't exist in .net standard, only .net core 3 |
|
Mmmmm.... I'm using Xamarin.Forms and the shared project compiles against .NET Standard. |
|
you don't use binding in shared projects, you only use it for the UI (Xamarin, wpf, etc..) |
|
I’m talking about Xamarin.Forms.
Trust me
Mauro Sampietro
… On 6 Feb 2020, at 17:41, bigworld12 ***@***.***> wrote:
you don't use binding in shared projects, you only use it for the UI (Xamarin, wpf, etc..)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I had a look at the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this doesn't change any files in the original project, it just adds 2 new projects ["CalcBinding.Core", WpfExample.Core"] that link items from the original project and build them against .net core 3