Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample HDR image looks too bright in Thorium v117 #18

Open
o-l-a-v opened this issue Nov 20, 2023 · 15 comments
Open

Sample HDR image looks too bright in Thorium v117 #18

o-l-a-v opened this issue Nov 20, 2023 · 15 comments

Comments

@o-l-a-v
Copy link

o-l-a-v commented Nov 20, 2023

Here's an image that looks too bright in Thorium v117.0.5938.157 (Official Build) (64-bit):

Found here:

Here's a screenshot:

231120 - Cat HDR in GIMP Paint NET XnView MP IrfanView Thorium

@Alex313031
Copy link
Owner

Alex313031 commented Jan 4, 2024

@o-l-a-v Might just need to update the libjxl library, see > #19

@Alex313031
Copy link
Owner

@o-l-a-v I updated it to 0.9.0 in the M120 version. Can you test?

@o-l-a-v
Copy link
Author

o-l-a-v commented Jan 25, 2024

@o-l-a-v I updated it to 0.9.0 in the M120 version. Can you test?

Thanks, will test tomorrow if I remember it. :)

@o-l-a-v
Copy link
Author

o-l-a-v commented Jan 25, 2024

@Alex313031

Thorium still struggles with this image. Thorium v120.0.6099.235 AVX2 to the right, GIMP to the left.

image

@Alex313031
Copy link
Owner

Alex313031 commented Jan 27, 2024

@o-l-a-v Nothing more I can do, as I cannot update the libjxl library past 0.9.0. They removed some stuff that it critical for integrating into blink in 0.9.1. Im sorry.

@Traneptora
Copy link

What was removed that was critical for integrating into blink?

@gz83
Copy link
Collaborator

gz83 commented Feb 7, 2024

What was removed that was critical for integrating into blink?

libjxl/libjxl@b08a704

The deleted things are here. We modified the code based on the patches provided by Google engineers, and the version numbers are consistent with those used by Google engineers.

@Traneptora

@Traneptora
Copy link

How are any of those things critical? Most of them are encoder settings, except for JxlDecoderGetDefaultPixelForamt which is noncritical (you either request an image in the pixel format you need, you look at the bit depth tag in the header if you want to use the image's tagged format).

@Alex313031
Copy link
Owner

@Traneptora @o-l-a-v @gz83 We fixed it, as they fixed it upstream. Now we are using libhighway 1.0.7, and libjxl 0.9.2.

@Alex313031
Copy link
Owner

@o-l-a-v @Traneptora Can you try the M121 version and report back

@o-l-a-v
Copy link
Author

o-l-a-v commented Feb 20, 2024

@Alex313031

They still don't look the same.

Screenshot 2024-02-20 160838

@gz83
Copy link
Collaborator

gz83 commented Feb 20, 2024

0.9.2 is the latest publicly released version. If you still cannot get the expected results, there may be other factors affecting it.

@o-l-a-v

@o-l-a-v
Copy link
Author

o-l-a-v commented Feb 20, 2024

0.9.2 is the latest publicly released version. If you still cannot get the expected results, there may be other factors affecting it.

@o-l-a-v

Sure, but that's out of my knowledge.

Thorium devs say "We fixed it, as they fixed it upstream." without even trying the test image in this issue original post apperently.
I just report that: No, the problem still persists.

Maybe @Traneptora or JXL devs have more knowledge about what causes this.

@Alex313031
Copy link
Owner

@o-l-a-v Dang, I'm sorry. No I didn't test, I just assumed it would fix it since 0.9.1 (and hence 0.9.2), is supposed to fix HDR issues.

@o-l-a-v
Copy link
Author

o-l-a-v commented Feb 20, 2024

No worries @Alex313031, I also understand that this could be out of your/Thorium's control. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants