Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The HDR metadata of the JXL image is not being utilized. #24

Open
lns103 opened this issue Feb 20, 2024 · 4 comments
Open

The HDR metadata of the JXL image is not being utilized. #24

lns103 opened this issue Feb 20, 2024 · 4 comments

Comments

@lns103
Copy link

lns103 commented Feb 20, 2024

I exported the same HDR image in AVIF and JXL formats using Adobe Camera Raw, but noticed color differences in Thorium. After investigation, I found that removing the brightness metadata from AVIF results in a display consistent with JXL.
I have confirmed that JXL contains brightness metadata using ExifTool.
I used ffmpeg -i hdr_metadata.avif -c copy no_hdr_metadata.avif to remove brightness metadata from the AVIF file.

CCV Primaries XY                : 0.7079,0.2920,0.1700,0.7970,0.1310,0.0460
CCV White XY                    : 0.3127,0.3290
CCV Min Luminance Nits          : 0.584496
CCV Max Luminance Nits          : 818.571806
CCV Avg Luminance Nits          : 89.355415

test_sample.zip

And this may help to fix. https://chromium-review.googlesource.com/c/chromium/src/+/4020332
This patch is from the Chromium team to add support for HDR metadata in AVIF. I haven't found any similar patches for JXL.

@gz83
Copy link
Collaborator

gz83 commented Feb 20, 2024

It may also be related to this issue. In addition, the patch you provided has already been included in Thorium. This is a patch that has been merged quite early.

#18

@lns103

@lns103
Copy link
Author

lns103 commented Feb 20, 2024

In addition, the patch you provided has already been included in Thorium. This is a patch that has been merged quite early.

This patch only affects AVIF images, and it has caused color differences between two images.

@lns103
Copy link
Author

lns103 commented Feb 21, 2024

Regarding #18, I believe it is caused by differences in Chromium's tone-mapping algorithm compared to other software. After re-exporting that image to AVIF using Adobe Camera Raw, the highlights in the image became brighter.
From my observations, the absence of brightness metadata in Chromium seems to result in a darker display, possibly because Chromium defaults to a peak brightness of 10000 nits for PQ content.

@gz83
Copy link
Collaborator

gz83 commented Feb 21, 2024

Could you please take a look at this issue and another issue?

another issue: #18

Thorium currently uses version 0.9.2 of libjxl

@mo271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants