Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorium Ungoogled edition #115

Closed
al3xxx opened this issue Mar 3, 2023 · 13 comments
Closed

Thorium Ungoogled edition #115

al3xxx opened this issue Mar 3, 2023 · 13 comments

Comments

@al3xxx
Copy link

al3xxx commented Mar 3, 2023

Hello Alex,
Is there any chance for thorium ungoogled edition?

@DI555
Copy link

DI555 commented Mar 3, 2023

yes, double that, but might better to start using ungoogled patches at all, i mean totally, in Thorium!

@ms178
Copy link

ms178 commented Mar 4, 2023

If there were only a source PKGBUILD for the AUR which could be customized for a couple of special flavors, it would lessen the burden on Alex to maintain too much versions himself and offer the flexibility that people could try out their favored Thorium flavor.

@Alex313031
Copy link
Owner

@al3xxx @DI555 @ms178 Thorium already uses some patches from ungoogled chromium, however one of my philosophies was to not hamper usability. So I have not included any patches that disable the web store, google search, or sync. However, privacy and security patches, including removing things that "phone home" to google (besides the bare minimum to make the above things work properly), have been integrated. I don't plan on making an ungoogled thorium, because that is alot of extra work. However, if you wanted to make an ungoogled build with the compiler optimizations of thorium, one could just set up a normal ungoogled build, but before actually compiling, copy this dir over the chromium tree > https://github.com/Alex313031/thorium/tree/main/src/build/config

@ms178
Copy link

ms178 commented Mar 4, 2023

@al3xxx @DI555 You might want to modify the PKGBUILD of that Ungoogled Chromium package: https://aur.archlinux.org/packages/ungoogled-chromium

It is a source package, so compiling Chromium yourself might take a while.

@DI555
Copy link

DI555 commented Mar 5, 2023

@Alex313031 , could you pls integrate to Thorium and all flagged ungoogled chromium patches (i mean those with flags)???
they all - are OPTIONAL/SWITCHABLE , cause all have flags, and very usefull , for example, - like uncrypted profile for portable using, keep all history(not only 90 days max) and force handle .crx file(to force installing extensions) !!!

here they all are:
github.com/ungoogled-software/ungoogled-chromium/blob/master/docs/flags.md

@gz83
Copy link
Collaborator

gz83 commented Mar 5, 2023

@Alex313031 , could you pls integrate to Thorium and all flagged ungoogled chromium patches (i mean those with flags)??? they all - are OPTIONAL/SWITCHABLE , cause all have flags, and very usefull , for example, - like uncrypted profile for portable using, keep all history(not only 90 days max) and force handle .crx file(to force installing extensions) !!!

here they all are: github.com/ungoogled-software/ungoogled-chromium/blob/master/docs/flags.md

@DI555

I think this is blind stamping. Adding a lot of flags is not a rational behavior. In addition, this will increase the development pressure on our team. If we want to add new flags, I think we must conduct a certain evaluation.

@Username23453
Copy link

Hey @DI555 , I cant find a way to message you, can we talk to each other about privacy, browsers, cyber security,etc? I know a lot about Thorium,etc. Heres my email: my_email111111@protonmail.com

@DI555
Copy link

DI555 commented Mar 5, 2023

@gz83 , but why not? - theese flags are great features for browser, really GREAT features!!!

@gz83
Copy link
Collaborator

gz83 commented Mar 5, 2023

@gz83 , but why not? - theese flags are great features for browser, really GREAT features!!!

@DI555

Adding more patches means that we need to modify more files, and the update method of Thorium's repo is manual rebase. When there are many files that need to be modified, the time required for rebase will be very long.

Also, the patches in ungoogled-chromium don't exactly work on Thorium. Even if we want to add them, our development team needs to select them in addition to evaluating them.

Alex is the person in charge of the entire project, and he will make the final decision on Thorium's function adjustments (addition or deletion), and we still need to listen to his opinions. @Alex313031

@Alex313031
Copy link
Owner

@gz83 I have added the unencrypted profile flags. I add flags on a case by case basis. I.E. if it is something almost everyone would want, or someone specifically asks for it.

It also wouldn't be as cut and dry as "add all the flags" because 1. I have added flags of my own, and that would cause file merge conflicts trying to use ungoogled's .patch, 2. as @gz83 said, not all of the flags would be applicable, and some of them I already have forced to true in source code, and 3. thorium is not always built to the same version as ungoogled, which introduces more issues.

If I could cleanly and easily add all of ungoogled's patches I would. But sorry. However, if there is a specific flag that you use alot and want me to add, you can tell me here or in another issue, and we will evaluate it.

@rmdhnreza
Copy link

Any chance adds disable qr, remove tabsearch & Omnibox Autocomplete Filtering flags? I know many people use that features, but I used Ungoogled Chromium because the flags are really useful for me.

@gz83
Copy link
Collaborator

gz83 commented Mar 8, 2023

Any chance adds disable qr, remove tabsearch & Omnibox Autocomplete Filtering flags? I know many people use that features, but I used Ungoogled Chromium because the flags are really useful for me.

@rmdhnreza

Thanks for your suggestion, we will evaluate whether to add these patches

@Flashwalker
Copy link

Flashwalker commented Mar 11, 2023

If any ungoogled patches have been applied, they are clearly not enough #119 (comment)

IMHO connections to any Google domain/service should only be made explicitly on demand.

@gz83 gz83 closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants