Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex said there would be an "Are you sure?" popup browser exit flag option added to newest release, I cant find it. #120

Closed
Username23453 opened this issue Mar 5, 2023 · 11 comments

Comments

@Username23453
Copy link

I checked the 45th Release notes & I cant find any mentioning of this flag that Alex speaks of. What is the name of this flag
so that I can search for it & find it?

Also, does thorium keep all browser history, instead of merely for 90 days? does thorium keep it all forever, by default?

And does thorium force handle .crx file,force installing extensions by default? is this a good idea?

@gz83
Copy link
Collaborator

gz83 commented Mar 5, 2023

I checked the 45th Release notes & I cant find any mentioning of this flag that Alex speaks of. What is the name of this flag so that I can search for it & find it?

Also, does thorium keep all browser history, instead of merely for 90 days? does thorium keep it all forever, by default?

And does thorium force handle .crx file,force installing extensions by default? is this a good idea?

@Intellectual234

The flag that pops up the confirmation window has not been added yet. Regarding other flags, my opinion has been published elsewhere
#115 (comment)

@Username23453
Copy link
Author

Username23453 commented Mar 6, 2023

@gz83 , alex just said it was added? Alex313031/Thorium-Win#28 (comment)

@gz83
Copy link
Collaborator

gz83 commented Mar 6, 2023

@gz83 , alex just said it was added? Alex313031/Thorium-Win#28 (comment)

@Intellectual234

I have verified that this flag has not been added to Thorium, and I will report this problem to Alex.

@Alex313031
Copy link
Owner

Alex313031 commented Mar 7, 2023

@Intellectual234 Im sorry. I was going to add it, however gz83 brought up an issue with localization. But @gz83 I think I can add that patch now, and we can worry about localization later, so we can get it out to him sooner. He was the one that asked for it anyway.

@Intellectual234 What platform are you using thorium on, so that I can make a release only for that, and just swap out the releases (i.e. not make a new release, but just edit the current one and delete/reupload the new one once it is built)

@Username23453
Copy link
Author

Right now I'm using thorium-browser_110.0.5481.178_amd64.deb for ZorinOS. Thorium's 45th release.
And thank you for modifying it :)

@gz83
Copy link
Collaborator

gz83 commented Mar 7, 2023

@Intellectual234 Im sorry. I was going to add it, however gz83 brought up an issue with localization. But @gz83 I think I can add that patch now, and we can worry about localization later, so we can get it out to him sooner. He was the one that asked for it anyway.

@Intellectual234 What platform are you using thorium on, so that I can make a release only for that, and just swap out the releases (i.e. not make a new release, but just edit the current one and delete/reupload the new one once it is built)

@Alex313031

I think we can deal with the localization of this patch later, and some other additional processes are needed to do localization

@Username23453
Copy link
Author

@gz83 , @Alex313031 , so when can i expect to be able to use a browser exit confirmation flag?

@gz83
Copy link
Collaborator

gz83 commented Mar 8, 2023

@gz83 , @Alex313031 , so when can i expect to be able to use a browser exit confirmation flag?

@Intellectual234

If this patch has been added to the repo, either I or Alex will remind you.

@Alex313031
Copy link
Owner

@Intellectual234 I added the flag, however it is only live in this linux build. Im gonna be making a Windows SSE3 build next. If you want an AVX or AVX2 build with the flag, you will have to wait until next M111 release.

Here: https://github.com/Alex313031/Thorium-Special/releases/tag/M110.0.5481.179-1

@Username23453
Copy link
Author

@Alex313031 , thank you buddy ol' pal! Whats the name of the flag exactly? so i can find it. :)

@gz83
Copy link
Collaborator

gz83 commented Mar 16, 2023

@Alex313031 , thank you buddy ol' pal! Whats the name of the flag exactly? so i can find it. :)

@Intellectual234

The name of the flag is "close-confirmation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants