Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unicorn version to 1.0.3 #28

Merged
merged 6 commits into from
May 31, 2021
Merged

Update unicorn version to 1.0.3 #28

merged 6 commits into from
May 31, 2021

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented May 28, 2021

This PR updates unicorn to latest version with all the bug fixes.

Additionally, it:
Update the build instructions on README as old Python 2.x and emsdk 1.x are deprecated
Fix build scripts as some of the build arguments get changed
Update unicorn wrapper as some use strict JavaScript mode throws error about two unused function argument uses the same _ as place holder

@AlexAltea
Copy link
Owner

Awesome, thank you @smeng9! Have you tested Unicorn.js after the changes?

@smeng9
Copy link
Contributor Author

smeng9 commented May 31, 2021 via email

@AlexAltea
Copy link
Owner

Great, thank you very much!

@AlexAltea AlexAltea merged commit a872af7 into AlexAltea:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants