Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a few compiler warnings and some typos that were actual errors. B... #2

Closed
wants to merge 2 commits into from

Conversation

jimrthy
Copy link

@jimrthy jimrthy commented Aug 16, 2013

For that issue I just created...I'm not sure how to associate the two.

I haven't had a chance to test it seriously (just verified that the basic-window example loads and runs without warnings), but it's all pretty simple and straightforward.

Well, except for adding a dependency to alexandria to use with-gensyms to ignore the error-code in def-error-callback. That probably wasn't such a hot idea.

James Ashley added 2 commits August 15, 2013 22:36
…. Biggest real changes are expanding the scope of the let in get-window-monitor and changing def-key-callback so it uses the mod-keys parameter rather than hard-coding the actual value
@AlexCharlton
Copy link
Owner

Thanks for finding and taking the time to fix these bugs! While I accepted ba6001b, I rewrote your changes in ef98721, mostly to avoid the Alexandria dependency.

A couple of notes that may or may not help you:

  • The behavior of with-gensyms is easily provided with a let.
  • (error (format nil "Local GLFW is version ~A.~A.~A" major minor rev)) is equivalent to (error "Local GLFW is version ~A.~A.~A" major minor rev)
  • You :used the package :cl-opengl in :cl-glfw3-examples, but then didn't take advantage of it. In any case, I had left that out intentionally, in order to make it clear what functions belonged to :gl.

And finally, FYI, you can refer to issues by writing a #, then the issue number (and github conveniently shows you what issue you are referring to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants