fix: removing element from an array doesn't insert null anymore #16 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbersac
commented
Nov 12, 2019
| @@ -655,6 +655,26 @@ describe('immupdate', () => { | |||
| expect(updated4).toNotBe(obj2) | |||
| }) | |||
|
|
|||
| it('can delete an element of an array', () => { | |||
There was a problem hiding this comment.
check if there is enough test.
gbersac
commented
Nov 12, 2019
| @@ -253,7 +258,7 @@ class _Updater { | |||
| const nextValue = clone(value) | |||
| const newHost = isLast ? host : nextValue | |||
|
|
|||
| host[this.data.field] = nextValue | |||
| if (nextValue !== undefined) host[this.data.field] = nextValue | |||
There was a problem hiding this comment.
This line has been modified to pass this test :
// test if nothing happen when the element to delete is widely out of array's bound
const updated3 = deepUpdate(data).at('a').at(5).set(DELETE)
expect(updated3).toEqual(data)Previous behaviour was to create the following object {a: [1, 2, 3, null, null]}
All unit tests pass, but I wonder, if it could introduced non tested regression.
gbersac
commented
Nov 12, 2019
| if (leafHostIsOption) { | ||
|
|
||
| if (Array.isArray(leafHost) && typeof field === 'number') { | ||
| if (field >= leafHost.length) return target |
There was a problem hiding this comment.
modifying this line to if (field >= leafHost.length || (field == leafHost.length && value !== DELETE)) return target should give the user the ability to append an element to the array (if this feature is valuable).
gbersac
force-pushed
the
fix/delete_from_array
branch
from
3bf90d8
to
2a67518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16
With this PR, trying to update an element which is out of bound of an array will do nothing (remove the ability to append an element at the end of an array).